Skip to content

[stable27] Move deprecation warnings to debug - #38980

Merged
szaimen merged 1 commit into
stable27from
backort/38852/stable27
Jun 24, 2023
Merged

[stable27] Move deprecation warnings to debug#38980
szaimen merged 1 commit into
stable27from
backort/38852/stable27

Conversation

@szaimen

Copy link
Copy Markdown
Contributor

Manual backport of #38852 to stable27

@szaimenszaimen added the 3. to review Waiting for reviews label Jun 24, 2023
@szaimenszaimen added this to the Nextcloud 27.0.1 milestone Jun 24, 2023
@szaimenszaimen changed the title Move deprecation warnings to debug[stable27] Move deprecation warnings to debugJun 24, 2023
@szaimen

Copy link
Copy Markdown
ContributorAuthor

/compile amend /

@szaimen

Copy link
Copy Markdown
ContributorAuthor

@skjnldsv

skjnldsv commented Jun 24, 2023

Copy link
Copy Markdown
Member

skjnldsv looks like the compile command fails? nextcloud/server/actions/runs/5365075296/jobs/9733658146

Looks like the path is different, I think we need to fix the workflow
https://github.com/nextcloud/.github/blob/4eca92e0661636a7815ad98e4c38c2408f71bef2/workflow-templates/command-compile.yml#L37-L45
EDIT: wrong reference, this is not where the path comes from

@skjnldsv

This comment was marked as resolved.

Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@szaimen

Copy link
Copy Markdown
ContributorAuthor

Why does it work now?

@skjnldsv

Copy link
Copy Markdown
Member

giphy

@szaimen
szaimen requested review from a team and nfebe and removed request for a teamJune 24, 2023 16:29
@szaimen
szaimen merged commit 8880e38 into stable27Jun 24, 2023
@szaimen
szaimen deleted the backort/38852/stable27 branch June 24, 2023 16:49
@szaimen

Copy link
Copy Markdown
ContributorAuthor

/backport to stable26

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@blizzzblizzz mentioned this pull request Jul 10, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@szaimen@skjnldsv@nfebe