Skip to content

adjust admin setup check to increase warning to configure https - #38915

Merged
szaimen merged 1 commit into
masterfrom
enh/noid/increase-https-warning
Jun 21, 2023
Merged

adjust admin setup check to increase warning to configure https#38915
szaimen merged 1 commit into
masterfrom
enh/noid/increase-https-warning

Conversation

@szaimen

@szaimenszaimen commented Jun 20, 2023

Copy link
Copy Markdown
Contributor

Close#36582

Reason: Without https some important web functionality like "copy to clipboard" or "service workers" does not work!

Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimenszaimen added the 3. to review Waiting for reviews label Jun 20, 2023
@szaimenszaimen added this to the Nextcloud 28 milestone Jun 20, 2023
@szaimen
szaimen requested a review from a teamJune 20, 2023 20:55
@szaimenszaimen changed the title adjust admin setup check to increase warning to set up httpsadjust admin setup check to increase warning to configure httpsJun 20, 2023
@szaimen
szaimen requested review from a team, Valdnet and rakeknivenJune 20, 2023 21:38
@szaimen
szaimen merged commit 5fb7ea2 into masterJun 21, 2023
@szaimen
szaimen deleted the enh/noid/increase-https-warning branch June 21, 2023 02:41
@szaimen

Copy link
Copy Markdown
ContributorAuthor

/backport to stable27

@szaimen

Copy link
Copy Markdown
ContributorAuthor

/backport to stable26

@szaimen

Copy link
Copy Markdown
ContributorAuthor

/backport to stable25

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin stable25
# Create the new backport branch
git checkout -b fix/foo-stable25
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@szaimen

Copy link
Copy Markdown
ContributorAuthor

/backport to stable27

@szaimen

Copy link
Copy Markdown
ContributorAuthor

/backport to stable26

@szaimen

Copy link
Copy Markdown
ContributorAuthor

/backport to stable25

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin stable25
# Create the new backport branch
git checkout -b fix/foo-stable25
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@szaimen

Copy link
Copy Markdown
ContributorAuthor

/backport to stable27

@szaimen

Copy link
Copy Markdown
ContributorAuthor

/backport to stable26

@szaimen

Copy link
Copy Markdown
ContributorAuthor

/backport to stable25

@olodar

Copy link
Copy Markdown

So what? Are you understand force users to use https is a stupid idea? https has much lower security than VPN encryption, this is first. Second, https in lan is not need, as in VPN.
You can simply warn that using via http may be unsecure, but this case is only when you're accesing from web (http://mysite.com).
Nextcloud developers mustn't force to use https!

@szaimen

szaimen commented Jul 20, 2023

Copy link
Copy Markdown
ContributorAuthor

It is not forced. It is just a warning. Also the things that we mentioned are actually enforced by the browser and not by us so no way to work around it.

@nextcloudnextcloud locked as resolved and limited conversation to collaborators Jul 20, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Copy link to clipboard broken when speeking plain http (https not affected) in 26.0.0.4 (beta 2)

4 participants

@szaimen@olodar@artonge@Pytal