Skip to content

fix setupcheck test - #39009

Closed
szaimen wants to merge 1 commit into
masterfrom
enh/noid/fix-setupcheck-test
Closed

fix setupcheck test#39009
szaimen wants to merge 1 commit into
masterfrom
enh/noid/fix-setupcheck-test

Conversation

@szaimen

Copy link
Copy Markdown
Contributor

Follow-up to #38915

Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimenszaimen added 3. to review Waiting for reviews regression labels Jun 26, 2023
@szaimenszaimen added this to the Nextcloud 28 milestone Jun 26, 2023
@szaimen

Copy link
Copy Markdown
ContributorAuthor

/backport to stable27

@szaimen

Copy link
Copy Markdown
ContributorAuthor

/backport to stable26

@szaimen

Copy link
Copy Markdown
ContributorAuthor

/backport to stable25

@szaimen
szaimen requested review from a team, Pytal, artonge and susnux and removed request for a teamJune 26, 2023 11:01
@susnux

Copy link
Copy Markdown
Contributor
  1. If it is just "recommended" why it is an error?
  2. HSTS is not required for "copy to clipboard" and "service workers", just HTTPS for connection (or wss) is enough, so this message might be misleading?

@szaimen

Copy link
Copy Markdown
ContributorAuthor

You are right. I adjusted the wrong place.

@szaimenszaimen closed this Jun 26, 2023
@szaimen
szaimen deleted the enh/noid/fix-setupcheck-test branch June 26, 2023 12:36
@szaimen

Copy link
Copy Markdown
ContributorAuthor

See #39014

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsregression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@szaimen@susnux@artonge