Skip to content

feat(admin_audit): Migrate to non-deprecated IEventDispatcher - #39086

Merged
blizzz merged 1 commit into
masterfrom
bugfix/noid/migrate-admin_audit-to-IEventDispatcher
Jul 5, 2023
Merged

feat(admin_audit): Migrate to non-deprecated IEventDispatcher#39086
blizzz merged 1 commit into
masterfrom
bugfix/noid/migrate-admin_audit-to-IEventDispatcher

Conversation

@nickvergessen

@nickvergessennickvergessen commented Jun 30, 2023•
edited
Loading

Copy link
Copy Markdown
Member

One step closer for #38546

Checklist

@nickvergessennickvergessen added this to the Nextcloud 28 milestone Jun 30, 2023
@nickvergessen
nickvergessen requested review from a team, ChristophWurst and come-ncJune 30, 2023 10:52
@nickvergessennickvergessen self-assigned this Jun 30, 2023
@nickvergessen
nickvergessen requested review from blizzz and icewind1991 and removed request for a teamJune 30, 2023 10:52
github-advanced-security[bot]
github-advanced-securityAI found potential problems Jun 30, 2023
View reviewed changes
Comment threadapps/admin_audit/lib/AppInfo/Application.php Fixed
Comment threadapps/admin_audit/lib/AppInfo/Application.php Fixed
ChristophWurst
ChristophWurst reviewed Jun 30, 2023
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do the full cleanup :)

Comment threadapps/admin_audit/lib/AppInfo/Application.php
@nickvergessen
nickvergessenforce-pushed the bugfix/noid/migrate-admin_audit-to-IEventDispatcher branch from 8b20f9c to d1ccd35CompareJune 30, 2023 12:28
@ChristophWurst

ChristophWurst commented Jul 3, 2023

Copy link
Copy Markdown
Member

Autoloader changes are probably caused by a new version of Composer

@nickvergessennickvergessen mentioned this pull request Jul 3, 2023
Merged
4 tasks
@nickvergessen
nickvergessenforce-pushed the bugfix/noid/migrate-admin_audit-to-IEventDispatcher branch from a8802fe to 158f080CompareJuly 4, 2023 07:33
@nickvergessen

nickvergessen commented Jul 4, 2023

Copy link
Copy Markdown
MemberAuthor

Rebased after #39089

@nickvergessen
feat(admin_audit): Migrate to non-deprecated IEventDispatcher
eb09053
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessenforce-pushed the bugfix/noid/migrate-admin_audit-to-IEventDispatcher branch from 158f080 to eb09053CompareJuly 4, 2023 10:36
@blizzz
blizzz merged commit c5285d6 into masterJul 5, 2023
@blizzz
blizzz deleted the bugfix/noid/migrate-admin_audit-to-IEventDispatcher branch July 5, 2023 10:05
@nickvergessennickvergessen mentioned this pull request Jul 6, 2023
Merged
4 tasks
@nickvergessennickvergessen added the pending documentation This pull request needs an associated documentation update label Jul 27, 2023
@nickvergessennickvergessen mentioned this pull request Jul 28, 2023
Merged
15 tasks
@nickvergessen

nickvergessen commented Jul 28, 2023

Copy link
Copy Markdown
MemberAuthor

Docs in nextcloud/documentation#10858

@nickvergessennickvergessen removed the pending documentation This pull request needs an associated documentation update label Jul 28, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@miaulalalamiaulalalamiaulalala approved these changes
@come-nccome-nccome-nc approved these changes
@icewind1991icewind1991Awaiting requested review from icewind1991icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@blizzzblizzzAwaiting requested review from blizzzblizzz is a code owner automatically assigned from nextcloud/server-backend

Assignees

@nickvergessennickvergessen

Labels

3. to reviewWaiting for reviewsenhancementfeature: admin audit

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

6 participants

@nickvergessen@ChristophWurst@miaulalala@github-advanced-security@come-nc@blizzz