Skip to content

Fix event names of 2FA related typed events - #39089

Merged
nickvergessen merged 1 commit into
masterfrom
bugfix/39087/fix-2fa-event-names
Jul 3, 2023
Merged

Fix event names of 2FA related typed events#39089
nickvergessen merged 1 commit into
masterfrom
bugfix/39087/fix-2fa-event-names

Conversation

@nickvergessen

@nickvergessennickvergessen commented Jun 30, 2023

Copy link
Copy Markdown
Member

Checklist

@nickvergessennickvergessen added this to the Nextcloud 28 milestone Jun 30, 2023
@nickvergessennickvergessen self-assigned this Jun 30, 2023
@nickvergessennickvergessen added the pending documentation This pull request needs an associated documentation update label Jun 30, 2023
@nickvergessennickvergessen mentioned this pull request Jun 30, 2023
Merged
5 tasks
@nickvergessen
nickvergessenforce-pushed the bugfix/39087/fix-2fa-event-names branch from cfca6a8 to 6de0ae2CompareJune 30, 2023 12:33
marcelklehr
marcelklehr reviewed Jun 30, 2023
View reviewed changes
Comment threadapps/admin_audit/composer/composer/installed.php
marcelklehr
marcelklehr reviewed Jun 30, 2023
View reviewed changes
Comment threadlib/public/Authentication/TwoFactorAuth/TwoFactorProviderForUserRegistered.php Outdated
@nickvergessen
nickvergessenforce-pushed the bugfix/39087/fix-2fa-event-names branch from 6de0ae2 to c544469CompareJuly 3, 2023 09:24
@nickvergessen

nickvergessen commented Jul 3, 2023

Copy link
Copy Markdown
MemberAuthor

Come and Christoph approved the commit in #39086 already, so setting to merge

@nickvergessen
nickvergessenforce-pushed the bugfix/39087/fix-2fa-event-names branch from c544469 to a87040eCompareJuly 3, 2023 09:36
@nickvergessen

nickvergessen commented Jul 3, 2023

Copy link
Copy Markdown
MemberAuthor

Forgot the since on the public function __construct() methods

@nickvergessen
Fix event names of 2FA related typed events
05aa39d
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessenforce-pushed the bugfix/39087/fix-2fa-event-names branch from a87040e to 05aa39dCompareJuly 3, 2023 12:25
@nickvergessen
nickvergessen merged commit 75d5fa4 into masterJul 3, 2023
@nickvergessen
nickvergessen deleted the bugfix/39087/fix-2fa-event-names branch July 3, 2023 13:38
@nickvergessennickvergessen removed the pending documentation This pull request needs an associated documentation update label Jul 28, 2023
@nickvergessen

nickvergessen commented Jul 28, 2023

Copy link
Copy Markdown
MemberAuthor

Docs in nextcloud/documentation#10858

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcelklehrmarcelklehrmarcelklehr approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@come-nccome-nccome-nc approved these changes
@rullzerrullzerAwaiting requested review from rullzer
@miaulalalamiaulalalaAwaiting requested review from miaulalalamiaulalala is a code owner

Assignees

@nickvergessennickvergessen

Labels

3. to reviewWaiting for reviewsbugfeature: authentication

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

Events of TwoFactor provider and manager names are very confusing (at best)

4 participants

@nickvergessen@marcelklehr@ChristophWurst@come-nc