Skip to content

Refactor core/BackgroundJobs - #39182

Merged
skjnldsv merged 2 commits into
nextcloud:masterfrom
shdehnavi:refactor_core_backgroundjobs
Feb 26, 2024
Merged

Refactor core/BackgroundJobs#39182
skjnldsv merged 2 commits into
nextcloud:masterfrom
shdehnavi:refactor_core_backgroundjobs

Conversation

@shdehnavi

@shdehnavishdehnavi commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

Summary

The required adjustments have been made to the classes in /core/BackgroundJobs namespace.

The improvements:

  • Adding return types

Checklist

@solracsfsolracsf added this to the Nextcloud 28 milestone Jul 6, 2023
@solracsfsolracsf added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Jul 6, 2023
github-advanced-security[bot]
github-advanced-securityAI found potential problems Jul 6, 2023
View reviewed changes
Comment threadcore/BackgroundJobs/BackgroundCleanupUpdaterBackupsJob.php Fixed
Comment threadcore/BackgroundJobs/BackgroundCleanupUpdaterBackupsJob.php Fixed
Comment threadcore/BackgroundJobs/LookupServerSendCheckBackgroundJob.php Fixed
Comment threadcore/BackgroundJobs/LookupServerSendCheckBackgroundJob.php Fixed
@shdehnavishdehnavi mentioned this pull request Jul 13, 2023
Merged
@shdehnavi
shdehnavi requested a review from skjnldsvJuly 14, 2023 12:13
@skjnldsvskjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzzblizzz modified the milestones: Nextcloud 28, Nextcloud 29Nov 23, 2023
@shdehnavi@come-nc
Refactor core/BackgroundJobs
47361fd
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@shdehnavi@come-nc
Make adjustments based on the review
246218d
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@come-nc
come-ncforce-pushed the refactor_core_backgroundjobs branch from 59278ed to 246218dCompareFebruary 26, 2024 08:22
@skjnldsv
skjnldsv merged commit 832e435 into nextcloud:masterFeb 26, 2024
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 26, 2024
@shdehnavi
shdehnavi deleted the refactor_core_backgroundjobs branch February 28, 2024 13:00
@blizzzblizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@come-nccome-nccome-nc approved these changes
@skjnldsvskjnldsvAwaiting requested review from skjnldsv

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishtechnical debt🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

7 participants

@shdehnavi@ChristophWurst@github-advanced-security@come-nc@blizzz@solracsf@skjnldsv