Skip to content

Refactor lib/private/App - #39299

Merged
skjnldsv merged 4 commits into
nextcloud:masterfrom
shdehnavi:refactor_lib_private_app
Feb 23, 2024
Merged

Refactor lib/private/App#39299
skjnldsv merged 4 commits into
nextcloud:masterfrom
shdehnavi:refactor_lib_private_app

Conversation

@shdehnavi

@shdehnavishdehnavi commented Jul 11, 2023

Copy link
Copy Markdown
Contributor

Summary

The required adjustments have been made to the following classes in the /lib/private/app namespace.

The improvements:

  • Using PHP8's constructor property promotion

Checklist

@solracsfsolracsf added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Jul 11, 2023
@solracsfsolracsf added this to the Nextcloud 28 milestone Jul 11, 2023
@shdehnavi

shdehnavi commented Jul 13, 2023

Copy link
Copy Markdown
ContributorAuthor

Hey @szaimen
The following PRs haven't been assigned to any reviewers yet.
Could you please be so kind and assign them to reviewers? bc I want to make the new PRs and still I have 30 open PRs.
#39249
#39246
#39245
#39244
#39243
#39236
#39235
#39226
#39217
#39216
#39215
#39213
#39212
#39211
#39209
#39208
#39183
#39182
#39177
#39176
#39175
#39174
#39173
#39163

@szaimen

szaimen commented Jul 13, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Hi @shdehnavi thanks a lot for the many PRs! Can you check if you can request the review itself? Usually you should be able to request reviews from the nextcloud/server-backend group. Does that work for you?

@shdehnavi

shdehnavi commented Jul 14, 2023

Copy link
Copy Markdown
ContributorAuthor

Hi @shdehnavi thanks a lot for the many PRs! Can you check if you can request the review itself? Usually you should be able to request reviews from the nextcloud/server-backend group. Does that work for you?

sure, i will do it

come-nc
come-nc reviewed Jul 18, 2023
View reviewed changes
Comment threadlib/private/App/AppStore/Fetcher/AppFetcher.php Outdated
@fsamapoor

fsamapoor commented Aug 14, 2023

Copy link
Copy Markdown
Member

Could you please resolve the conflicts?

@shdehnavi
shdehnaviforce-pushed the refactor_lib_private_app branch from 15b7c09 to 901f15aCompareAugust 16, 2023 06:35
github-advanced-security[bot]
github-advanced-securityAI found potential problems Aug 16, 2023
View reviewed changes
Comment threadlib/private/App/AppManager.php Fixed
@skjnldsvskjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzzblizzz modified the milestones: Nextcloud 28, Nextcloud 29Nov 23, 2023
@shdehnavi
shdehnaviforce-pushed the refactor_lib_private_app branch from 901f15a to 0eeea83CompareDecember 11, 2023 13:03
@shdehnavi

shdehnavi commented Dec 11, 2023

Copy link
Copy Markdown
ContributorAuthor

@blizzz All conflicts have been resolved, Ready to merge.

shdehnaviand others added 4 commits February 23, 2024 15:53
@shdehnavi@skjnldsv
Refactor lib/private/App
84749d5
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@shdehnavi@skjnldsv
Fix code style
7a8d79b
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@shdehnavi@juliusknorr@skjnldsv
Make adjustments based on the psalm review
b6ef67e
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
Co-authored-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@shdehnavi@skjnldsv
Fix psalm errors
cf17db2
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@skjnldsv
skjnldsvforce-pushed the refactor_lib_private_app branch from c3cb6fc to cf17db2CompareFebruary 23, 2024 14:53
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 23, 2024
@skjnldsv
skjnldsv disabled auto-merge February 23, 2024 18:24
@skjnldsv
skjnldsv merged commit c4975b3 into nextcloud:masterFeb 23, 2024
@blizzzblizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fsamapoorfsamapoorfsamapoor approved these changes
@come-nccome-nccome-nc approved these changes
@tcitworldtcitworldAwaiting requested review from tcitworld

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishtechnical debt🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

8 participants

@shdehnavi@szaimen@fsamapoor@github-advanced-security@come-nc@blizzz@solracsf@skjnldsv