Uh oh!
There was an error while loading. Please reload this page.
Refactor core/Command/App - #39183
Merged
Merged
Conversation
/lib/private/Remote namespace. The improvements: - Using PHP8's constructor property promotion - Adding return types - Adding throws types - Adding types to properties - Using PHP8's match expression instead of switch ## Checklist - Code is [properly formatted](https://docs.nextcloud.com/server/latest/developer_manual/digging_deeper/continuous_integration.html#linting) - [Sign-off message](https://github.com/src-d/guide/blob/master/developer-community/fix-DCO.md) is added to all commitsRefactor core/Command/AppChristophWurst
approved these changes
Jul 6, 2023
nickvergessen
requested changes
Jul 17, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
fsamapoor
approved these changes
Sep 29, 2023
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
Co-authored-by: Joas Schilling <coding@schilljs.com> Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
Co-authored-by: Joas Schilling <coding@schilljs.com> Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
fsamapoorforce-pushed
the
refactor_core_command_app
branch
from
September 29, 2023 08:07
f8da58f to
3658894Comparenickvergessen
approved these changes
Sep 29, 2023
nickvergessen
enabled auto-merge
September 29, 2023 08:31
Merged
skjnldsv
disabled auto-merge
February 23, 2024 18:46
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The required adjustments have been made to the classes in
/core/Command/Appnamespace.The improvements:
Checklist