Uh oh!
There was an error while loading. Please reload this page.
Use PHP8's match expression instead of switch - #39208
Closed
shdehnavi wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
| return IQueryBuilder::PARAM_STR; | ||
| return match ($types[$property]) { | ||
| 'int', 'integer' => IQueryBuilder::PARAM_INT, |
There was a problem hiding this comment.
As mentioned in the talk PR I think this decreases readability and since it has no advantage we shouldn't do it, so that patches in the area can be backported with less chance for conflicts.
nickvergessen
commented
Jul 17, 2023
Member
Closing as per comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The required adjustments have been made to the classes in the
/lib/publicnamespace.The improvements:
matchexpression instead ofswitchChecklist