Refactor core/Controller by shdehnavi · Pull Request #39212 · nextcloud/server

shdehnavi · 2023-07-07T00:53:27Z

Summary

The required adjustments have been made to the classes in /core/Controller namespace.

The improvements:

Adding return types
Adding throws types
Adding types to properties
Replacing qualifiers with imports
Updating doc blocks
Using PHP8's str_starts_with and str_ends_with instead of substr

Checklist

Code is properly formatted
Sign-off message is added to all commits

Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

Co-authored-by: Joas Schilling <coding@schilljs.com> Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

Co-authored-by: Louis Chemineau <louis@chmn.me> Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

nickvergessen · 2023-07-19T18:48:05Z

+ * @param Node $node
+ * @param int $x
+ * @param int $y
+ * @param bool $a
+ * @param bool $forceIcon
+ * @param string $mode
+ * @return Response
+ * @throws NotFoundException
+ * @throws InvalidPathException


nickvergessen · 2023-07-19T18:48:41Z

 *
+ * @param int $fileId
+ * @param int $x
+ * @param int $y
+ * @param bool $a
+ * @param bool $forceIcon
+ * @param string $mode
 * @return DataResponse|FileDisplayResponse
+ * @throws NoUserException
+ * @throws NotPermittedException


nickvergessen · 2023-07-19T18:48:54Z

+ * @param string $targetUserId
+ * @param string $paramId
+ * @param string $visibility
+ * @return DataResponse
+ * @throws OCSBadRequestException
+ * @throws OCSForbiddenException
+ * @throws OCSNotFoundException
+ * @throws Exception


another open comment here

Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

Refactor core/Controller
f48db5a
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

solracsf added this to the Nextcloud 28 milestone Jul 9, 2023

solracsf added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Jul 9, 2023

shdehnavi mentioned this pull request Jul 13, 2023
Refactor lib/private/App #39299
Merged

shdehnavi requested review from artonge and nickvergessen July 14, 2023 12:12

nickvergessen reviewed Jul 14, 2023
View reviewed changes

Comment threadcore/Controller/GuestAvatarController.php Outdated
Comment threadcore/Controller/LoginController.php Outdated
Comment threadcore/Controller/PreviewController.php Outdated
Comment threadcore/Controller/PreviewController.php Outdated

shdehnaviand others added 4 commits July 14, 2023 17:31

Update core/Controller/GuestAvatarController.php
51040b1
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

Make adjustments based on the review
be9e908
Co-authored-by: Joas Schilling <coding@schilljs.com> Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

Make adjustments based on the review
7e4ca27
Co-authored-by: Joas Schilling <coding@schilljs.com> Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

Make adjustments based on the review
dbda422
Co-authored-by: Joas Schilling <coding@schilljs.com> Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

shdehnavi requested a review from nickvergessen July 16, 2023 12:28

artonge reviewed Jul 17, 2023
View reviewed changes

Comment threadcore/Controller/ClientFlowLoginController.php Outdated

nickvergessen requested changes Jul 17, 2023
View reviewed changes

shdehnaviand others added 10 commits July 19, 2023 15:52

Update core/Controller/ClientFlowLoginController.php
8913eb8
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

Update core/Controller/CssController.php
f24dc3f
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

Update core/Controller/ContactsMenuController.php
bc5dbd2
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

Update core/Controller/JsController.php
1c942b4
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

Update core/Controller/LoginController.php
2302df8
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

Update core/Controller/TwoFactorChallengeController.php
ee576ef
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

Update core/Controller/TwoFactorChallengeController.php
b169a24
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

Update core/Controller/TwoFactorChallengeController.php
f2b03d1
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

Update core/Controller/WellKnownController.php
cd4bbc5
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

Update core/Controller/TwoFactorChallengeController.php
c54a665
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

shdehnavi requested review from artonge and nickvergessen July 19, 2023 12:31

Make adjustments based on the review
dde0ef7
Co-authored-by: Louis Chemineau <louis@chmn.me> Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

nickvergessen requested changes Jul 19, 2023
View reviewed changes

Make adjustments based on the review
78a0f52
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

shdehnavi requested a review from nickvergessen July 24, 2023 11:52

skjnldsv mentioned this pull request Nov 1, 2023
chore: 28.0.0 beta 1 #41228
Merged

This was referenced Nov 6, 2023
28.0.0 beta 2 #41314
Merged
28.0.0 beta 3 #41379
Merged

This was referenced Nov 14, 2023
28.0.0 beta 4 #41477
Merged
28.0.0 RC1 #41621
Merged

blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023

This was referenced Mar 12, 2024
29.0.0 beta 2 #44152
Merged
29.0.0 beta 3 #44186
Merged
29.0.0 beta 4 #44275
Merged

This was referenced Mar 20, 2024
29.0.0 beta 5 #44361
Merged
29.0.0 beta 6 #44449
Merged

skjnldsv mentioned this pull request Mar 28, 2024
29.0.0 RC1 #44552
Merged
81 tasks

skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024

skjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Jul 27, 2024

This was referenced Jul 30, 2024
30.0.0 beta 2 #46870
Merged
30.0.0 beta 3 #46946
Merged

skjnldsv closed this Aug 3, 2024

skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024

Navigation Menu

Uh oh!

Uh oh!

Refactor core/Controller - #39212

Refactor core/Controller#39212
shdehnavi wants to merge 17 commits into
nextcloud:masterfrom
shdehnavi:refactor_core_controller

shdehnavi commented Jul 7, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nickvergessenJul 19, 2023

Uh oh!

nickvergessenJul 19, 2023

Uh oh!

nickvergessenJul 19, 2023

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

shdehnavi commented Jul 7, 2023

Summary

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nickvergessenJul 19, 2023

Choose a reason for hiding this comment

Uh oh!

nickvergessenJul 19, 2023

Choose a reason for hiding this comment

Uh oh!

nickvergessenJul 19, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants