Skip to content

Refactor "substr" calls in lib/public to improve code readability - #39217

Merged
skjnldsv merged 1 commit into
nextcloud:masterfrom
shdehnavi:replace_substr_call_in_lib_public
Aug 6, 2024
Merged

Refactor "substr" calls in lib/public to improve code readability#39217
skjnldsv merged 1 commit into
nextcloud:masterfrom
shdehnavi:replace_substr_call_in_lib_public

Conversation

@shdehnavi

@shdehnavishdehnavi commented Jul 7, 2023

Copy link
Copy Markdown
Contributor

Summary

Replacing substr with str_ends_with in the /lib/public namespace to improve code readability

Checklist

@shdehnavishdehnavi changed the title Refactor "substr" calls to improve code readabilityRefactor "substr" calls in lib/public to improve code readabilityJul 7, 2023
@solracsfsolracsf added this to the Nextcloud 28 milestone Jul 9, 2023
@solracsfsolracsf added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Jul 9, 2023
@shdehnavishdehnavi mentioned this pull request Jul 13, 2023
Merged
@skjnldsvskjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzzblizzz modified the milestones: Nextcloud 28, Nextcloud 29Nov 23, 2023
@AndyScherzinger
AndyScherzingerforce-pushed the replace_substr_call_in_lib_public branch from 621dc79 to c9e4413CompareFebruary 27, 2024 13:24
This was referenced Mar 12, 2024
Merged
Merged
Merged
This was referenced Mar 20, 2024
Merged
Merged
@skjnldsvskjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
@skjnldsvskjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Jul 27, 2024
This was referenced Jul 30, 2024
Merged
Merged
juliusknorr
juliusknorr requested changes Aug 1, 2024
View reviewed changes

@juliusknorrjuliusknorr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but needs a rebase and fix of the commit message for conventional commits :)

@skjnldsvskjnldsv closed this Aug 3, 2024
@skjnldsvskjnldsv reopened this Aug 6, 2024
@shdehnavi@skjnldsv
chore: refactor "substr" calls to improve code readability
f19f8fd
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@skjnldsv
skjnldsvforce-pushed the replace_substr_call_in_lib_public branch from c9e4413 to f19f8fdCompareAugust 6, 2024 06:47
@skjnldsv
skjnldsv merged commit ead0471 into nextcloud:masterAug 6, 2024
@AltahrimAltahrim mentioned this pull request Aug 6, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr

Assignees

No one assigned

Labels

2. developingWork in progressstaleTicket or PR with no recent activitytechnical debt🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 30

Development

Successfully merging this pull request may close these issues.

6 participants

@shdehnavi@nickvergessen@juliusknorr@skjnldsv@blizzz@solracsf