Skip to content

Refactor contactsinteraction app - #39243

Merged
AndyScherzinger merged 2 commits into
nextcloud:masterfrom
shdehnavi:refactor_contactsinteraction_app
Aug 29, 2023
Merged

Refactor contactsinteraction app#39243
AndyScherzinger merged 2 commits into
nextcloud:masterfrom
shdehnavi:refactor_contactsinteraction_app

Conversation

@shdehnavi

Copy link
Copy Markdown
Contributor

Summary

The required adjustments have been made to the contactsinteraction app.

The improvements:

  • Adding return types
  • Adding types to properties
  • Adding throw types
  • Using PHP8's constructor property promotion

Checklist

@solracsfsolracsf added this to the Nextcloud 28 milestone Jul 9, 2023
@solracsfsolracsf added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Jul 9, 2023
@shdehnavishdehnavi mentioned this pull request Jul 13, 2023
Comment threadapps/contactsinteraction/lib/BackgroundJob/CleanupJob.php Fixed
@kesselb
kesselbforce-pushed the refactor_contactsinteraction_app branch from 84e3719 to c9b2007CompareAugust 24, 2023 14:22

@kesselbkesselb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🧹

@kesselb
kesselbforce-pushed the refactor_contactsinteraction_app branch from c9b2007 to bab4955CompareAugust 28, 2023 12:11
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@kesselb
kesselbforce-pushed the refactor_contactsinteraction_app branch from bab4955 to e1b33e6CompareAugust 29, 2023 09:35
@AndyScherzinger
AndyScherzinger merged commit ad56458 into nextcloud:masterAug 29, 2023
@welcome

welcomeBot commented Aug 29, 2023

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewstechnical debt🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@shdehnavi@kesselb@miaulalala@github-advanced-security@AndyScherzinger@solracsf