Skip to content

Refactor lib/private - #39246

Closed
shdehnavi wants to merge 1 commit into
nextcloud:masterfrom
shdehnavi:refactor_lib_private_root_classes_part2
Closed

Refactor lib/private#39246
shdehnavi wants to merge 1 commit into
nextcloud:masterfrom
shdehnavi:refactor_lib_private_root_classes_part2

Conversation

@shdehnavi

@shdehnavishdehnavi commented Jul 8, 2023

Copy link
Copy Markdown
Contributor

Summary

The required adjustments have been made to the following classes under /lib/private namespace:

  • Setup.php
  • Streamer.php
  • StreamImage.php
  • SubAdmin.php
  • SystemConfig.php

The improvements:

  • Using PHP8's constructor property promotion
  • Adding return types
  • Adding types to properties
  • Updating doc blocks

Checklist

Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@solracsfsolracsf added this to the Nextcloud 28 milestone Jul 9, 2023
@solracsfsolracsf added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Jul 9, 2023
@shdehnavishdehnavi mentioned this pull request Jul 13, 2023
@skjnldsvskjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
@blizzzblizzz modified the milestones: Nextcloud 28, Nextcloud 29Nov 23, 2023
This was referenced Mar 12, 2024
This was referenced Mar 20, 2024
@skjnldsvskjnldsv mentioned this pull request Mar 28, 2024
81 tasks
@skjnldsv

Copy link
Copy Markdown
Member

Please resolve conflicts :)

@skjnldsvskjnldsv added stale Ticket or PR with no recent activity 2. developing Work in progress and removed 3. to review Waiting for reviews labels May 30, 2024
@blizzzblizzz mentioned this pull request Jul 30, 2024
@blizzzblizzz mentioned this pull request Aug 1, 2024
This was referenced Aug 5, 2024
@skjnldsvskjnldsv mentioned this pull request Aug 13, 2024
@skjnldsvskjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
@skjnldsv

Copy link
Copy Markdown
Member

@shdehnavi thanks for the PR (and all the other ones too! 💪)
Unfortunately, we took a bit too much time to review and get it merged.
We rebased and merged as much as we can for the other, but this one was too conflicting.

If you used a tooling to create those, feel free to run it again now and ping me @skjnldsv straight away! I'll help you get it merged fast 🚀

Have a nice day :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developingWork in progressstaleTicket or PR with no recent activitytechnical debt🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@shdehnavi@skjnldsv@icewind1991@blizzz@solracsf