Skip to content

fix(comments): Emit CommentsEntityEvent as typed event - #39304

Merged
nickvergessen merged 1 commit into
masterfrom
bugfix/noid/typed-event-comments-entity
Jul 19, 2023
Merged

fix(comments): Emit CommentsEntityEvent as typed event#39304
nickvergessen merged 1 commit into
masterfrom
bugfix/noid/typed-event-comments-entity

Conversation

@nickvergessen

@nickvergessennickvergessen commented Jul 11, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Fix#1539

Checklist

@nickvergessennickvergessen added enhancement 3. to review Waiting for reviews feature: dav feature: comments pending documentation This pull request needs an associated documentation update labels Jul 11, 2023
@nickvergessennickvergessen added this to the Nextcloud 28 milestone Jul 11, 2023
@nickvergessennickvergessen self-assigned this Jul 11, 2023
@nickvergessen
nickvergessen requested review from ArtificialOwl, icewind1991 and nfebe and removed request for a teamJuly 11, 2023 09:10
@nickvergessen
nickvergessen marked this pull request as draft July 11, 2023 09:57
@nickvergessennickvergessen mentioned this pull request Jul 13, 2023
Closed
@nickvergessen
nickvergessenforce-pushed the bugfix/noid/typed-event-comments-entity branch from de58d50 to 5cc8c03CompareJuly 18, 2023 12:45
@nickvergessen
fix(comments): Emit CommentsEntityEvent as typed event
c3bc575
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessenforce-pushed the bugfix/noid/typed-event-comments-entity branch from 5cc8c03 to c3bc575CompareJuly 18, 2023 14:20
@nickvergessen
nickvergessen marked this pull request as ready for review July 18, 2023 14:21
kesselb
kesselb approved these changes Jul 18, 2023
View reviewed changes

@kesselbkesselb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@nickvergessen
nickvergessen merged commit 489b480 into masterJul 19, 2023
@nickvergessen
nickvergessen deleted the bugfix/noid/typed-event-comments-entity branch July 19, 2023 15:25
@nickvergessennickvergessen mentioned this pull request Jul 28, 2023
Merged
15 tasks
@nickvergessennickvergessen removed the pending documentation This pull request needs an associated documentation update label Jul 28, 2023
@nickvergessen

nickvergessen commented Jul 28, 2023

Copy link
Copy Markdown
MemberAuthor

Docs in nextcloud/documentation#10858

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcelklehrmarcelklehrmarcelklehr approved these changes
@kesselbkesselbkesselb approved these changes
@come-nccome-nccome-nc approved these changes
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@icewind1991icewind1991Awaiting requested review from icewind1991icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-backend

Assignees

@nickvergessennickvergessen

Labels

3. to reviewWaiting for reviewsenhancementfeature: commentsfeature: dav

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

Comments: Replace CommentEntityEvent with a registration-bases solution within CommentsManager.

4 participants

@nickvergessen@marcelklehr@kesselb@come-nc