Uh oh!
There was an error while loading. Please reload this page.
feat(dav): Emit a typed event to deprecate OCA\DAV\Connector\Sabre::addPlugin - #39305
Merged
Conversation
nickvergessen
requested review from
ArtificialOwl and icewind1991
and removed request for
a teamJuly 11, 2023 09:56
5 tasks
Uh oh!
There was an error while loading. Please reload this page.
nickvergessenforce-pushed
the
bugfix/noid/sabre-plugin-events
branch
from
July 14, 2023 09:43
8245c21 to
f2edad2Comparecome-nc
approved these changes
Jul 17, 2023
…ddPlugin Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessenforce-pushed
the
bugfix/noid/sabre-plugin-events
branch
from
July 17, 2023 14:06
f2edad2 to
72667a6Comparekesselb
commented
Jul 18, 2023
Contributor
Super nitpick suggestion: Rename SabrePluginAddEvent to SabrePluginAddPluginEvent To use the same "pattern" as for SabrePluginAuthInitEvent ;)
|
kesselb
approved these changes
Jul 18, 2023
kesselb
reviewed
Jul 18, 2023
| // allow setup of additional plugins | ||
| $event = new \OCP\SabrePluginEvent($server); | ||
| $dispatcher->dispatch('OCA\DAV\Connector\Sabre::addPlugin', $event); | ||
| $event = new \OCA\DAV\Events\SabrePluginAddEvent($server); |
Contributor
There was a problem hiding this comment.
Suggested change
| $event = new \OCA\DAV\Events\SabrePluginAddEvent($server); | |
| $typedEvent = new \OCA\DAV\Events\SabrePluginAddEvent($server); |
| $event = new \OCP\SabrePluginEvent($server); | ||
| $dispatcher->dispatch('OCA\DAV\Connector\Sabre::addPlugin', $event); | ||
| $event = new \OCA\DAV\Events\SabrePluginAddEvent($server); | ||
| $dispatcher->dispatchTyped($event); |
Contributor
There was a problem hiding this comment.
Suggested change
| $dispatcher->dispatchTyped($event); | |
| $dispatcher->dispatchTyped($typedEvent); |
nickvergessen
commented
Jul 18, 2023
MemberAuthor
I'll pass on this one with: https://docs.nextcloud.com/server/latest/developer_manual/basics/events.html#naming-scheme
|
15 tasks
nickvergessen
commented
Jul 28, 2023
MemberAuthor
Docs in nextcloud/documentation#10858 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist