Skip to content

files_external: Add OpenAPI spec - #39321

Merged
icewind1991 merged 1 commit into
masterfrom
feature/openapi/files_external
Jul 13, 2023
Merged

files_external: Add OpenAPI spec#39321
icewind1991 merged 1 commit into
masterfrom
feature/openapi/files_external

Conversation

@provokateurin

Copy link
Copy Markdown
Member

Summary

From #36666. Adds the necessary annotations and descriptions.

Checklist

Signed-off-by: jld3103 <jld3103yt@gmail.com>
Comment threadapps/files_external/openapi.json
@provokateurin

Copy link
Copy Markdown
MemberAuthor

@artonge@icewind1991 Can you help me with the CI failure? I don't see why my changes would cause any failure since they only add annotations which are completely ignored at runtime, thus no behavioral changes were made afaict

@artongeartonge left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some of those tests are triggered only when some specific files are edited.
They might be failing for a long time 🙈 .
As your changes are mostly comments, I think we can merge without further concern.
If @icewind1991 agrees, feel free to merge :)

@provokateurin

Copy link
Copy Markdown
MemberAuthor

Yeah I already imagined something like that. There is no way the comments can break something

@icewind1991
icewind1991 merged commit c3c58b6 into masterJul 13, 2023
@icewind1991
icewind1991 deleted the feature/openapi/files_external branch July 13, 2023 14:02
@icewind1991

Copy link
Copy Markdown
Member

S3 external test fix is here: #39367

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@provokateurin@icewind1991@artonge@bigcat88