Skip to content

handle more exceptions in AmazonS3::fopen - #39367

Merged
icewind1991 merged 2 commits into
masterfrom
s3-fopen-exception
Jul 20, 2023
Merged

handle more exceptions in AmazonS3::fopen#39367
icewind1991 merged 2 commits into
masterfrom
s3-fopen-exception

Conversation

@icewind1991

Copy link
Copy Markdown
Member

returning false instead of throwing is the expected behavior.

Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991icewind1991 added the 3. to review Waiting for reviews label Jul 13, 2023
@icewind1991icewind1991 added this to the Nextcloud 28 milestone Jul 13, 2023
@icewind1991
icewind1991 requested review from a team, ArtificialOwl, come-nc and nfebe and removed request for a teamJuly 13, 2023 13:40
@icewind1991icewind1991 mentioned this pull request Jul 13, 2023
4 tasks
@icewind1991

Copy link
Copy Markdown
MemberAuthor

Other failing external storage tests

  • vsftpd is a docker related issue
  • kerberos sso is "complicated" and probably needs adjustments to the scripted setup

@icewind1991
icewind1991 merged commit 31f1ff8 into masterJul 20, 2023
@icewind1991
icewind1991 deleted the s3-fopen-exception branch July 20, 2023 17:32
@icewind1991

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

@icewind1991

Copy link
Copy Markdown
MemberAuthor

/backport to stable26

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991@Pytal@come-nc