Uh oh!
There was an error while loading. Please reload this page.
files_external: getStorage before remove - #39323
Merged
Merged
Conversation
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
ArtificialOwl
commented
Jul 11, 2023
MemberAuthor
/backport to stable27 |
ArtificialOwl
commented
Jul 11, 2023
MemberAuthor
/backport to stable26 |
ArtificialOwl
commented
Jul 11, 2023
MemberAuthor
/backport to stable25 |
| return ($config->getApplicableUsers() === [$this->getUser()->getUID()]) && $config->getType() === StorageConfig::MOUNT_TYPE_PERSONAl; | ||
| } | ||
| public function removeStorage($id) { |
Check notice
Code scanning / Psalm
MissingReturnType
ArtificialOwl
commented
Jul 11, 2023
MemberAuthor
/backport to stable24 |
ArtificialOwl
commented
Jul 11, 2023
MemberAuthor
/backport to stable23 |
ArtificialOwl
commented
Jul 11, 2023
MemberAuthor
errors are not related |
ArtificialOwl
requested review from
a team, AndyScherzinger, come-nc, icewind1991, nfebe and nickvergessen
and removed request for
a teamJuly 11, 2023 20:50
AndyScherzinger
approved these changes
Jul 13, 2023
This was referenced Jul 13, 2023
This was referenced Jul 13, 2023
The backport to stable24 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable24
git pull origin stable24
# Create the new backport branch
git checkout -b fix/foo-stable24
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable24More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
The backport to stable23 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable23
git pull origin stable23
# Create the new backport branch
git checkout -b fix/foo-stable23
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable23More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.