Skip to content

[stable27] getStorage before remove - #39354

Merged
AndyScherzinger merged 1 commit into
stable27from
backport/39323/39323-stable27
Jul 13, 2023
Merged

[stable27] getStorage before remove#39354
AndyScherzinger merged 1 commit into
stable27from
backport/39323/39323-stable27

Conversation

@ArtificialOwl

Copy link
Copy Markdown
Member

backport of #39323

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
return ($config->getApplicableUsers() === [$this->getUser()->getUID()]) && $config->getType() === StorageConfig::MOUNT_TYPE_PERSONAl;
}

public function removeStorage($id) {

Check notice

Code scanning / Psalm

MissingReturnType

Method OCA\Files_External\Service\UserStoragesService::removeStorage does not have a return type, expecting void
@blizzzblizzz added this to the Nextcloud 27.0.1 milestone Jul 13, 2023
@blizzzblizzz added the 3. to review Waiting for reviews label Jul 13, 2023
@blizzzblizzz mentioned this pull request Jul 13, 2023
@AndyScherzinger
AndyScherzinger merged commit 8822258 into stable27Jul 13, 2023
@AndyScherzinger
AndyScherzinger deleted the backport/39323/39323-stable27 branch July 13, 2023 12:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ArtificialOwl@AndyScherzinger@blizzz@github-advanced-security