Uh oh!
There was an error while loading. Please reload this page.
Improve sharing flow - #39472
Merged
Merged
Conversation
nfebeforce-pushed
the
26691-improve-sharing-design-flow
branch
4 times, most recently
from
July 28, 2023 09:02
7cf0c6c to
f1e8fdaComparenfebeforce-pushed
the
26691-improve-sharing-design-flow
branch
9 times, most recently
from
August 7, 2023 00:14
d0ab2b1 to
c10f540Comparenfebe
commented
Aug 7, 2023
ContributorAuthor
Share Details View
|
This comment was marked as resolved.
This comment was marked as resolved.
nfebeforce-pushed
the
26691-improve-sharing-design-flow
branch
from
August 9, 2023 09:58
c10f540 to
c029526Comparejancborchardt
requested review from
marcoambrosini, nimishavijay, skjnldsv and szaimenAugust 9, 2023 13:13
nfebeforce-pushed
the
26691-improve-sharing-design-flow
branch
from
August 9, 2023 19:04
c029526 to
058db4cCompare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
nfebeforce-pushed
the
26691-improve-sharing-design-flow
branch
2 times, most recently
from
August 13, 2023 16:16
6e7f0d4 to
7df89e8Compare Merged
artonge
reviewed
Aug 30, 2023
| <!-- share details --> | ||
| <div v-else> | ||
| <SharingDetailsTab :file-info="shareDetailsData.fileInfo" |
Collaborator
There was a problem hiding this comment.
Any reason to use shareDetailsData.fileInfo instead of fileInfo ?
artonge
reviewed
Aug 30, 2023
| return null | ||
| } | ||
| const expirationTime = moment(this.share.passwordExpirationTime) |
Collaborator
There was a problem hiding this comment.
You need to import moment.
importmomentfrom"@nextcloud/moment"3 tasks
artonge
reviewed
Aug 30, 2023
Uh oh!
There was an error while loading. Please reload this page.
artonge
approved these changes
Aug 30, 2023
AndyScherzinger
approved these changes
Aug 30, 2023
artonge
dismissed stale reviews from jancborchardt and szaimenAugust 30, 2023 15:38
Will be in a follow up if still relevent
nfebeforce-pushed
the
26691-improve-sharing-design-flow
branch
2 times, most recently
from
August 30, 2023 15:54
321e905 to
488dcfbCompareThis commit introduces the following changes: - Does not create new share once user is selected for internal shares - Adds a `SharingDetails` view for share configurations - Adds a quick share select to enable fast changes in share permisions. Resolves: #26691 Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
commented
Aug 30, 2023
Collaborator
Backport to stable27: #40166 |
artongeforce-pushed
the
26691-improve-sharing-design-flow
branch
from
August 30, 2023 16:18
488dcfb to
79f6263Compare23 tasks
Merged
4 tasks
6 tasks
7 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves: #26691