Skip to content

fix(files_sharing): global search in sharing tab - #45922

Draft
ShGKme wants to merge 4 commits into
masterfrom
fix/files_sharing--global-search-in-select
Draft

fix(files_sharing): global search in sharing tab#45922
ShGKme wants to merge 4 commits into
masterfrom
fix/files_sharing--global-search-in-select

Conversation

@ShGKme

Copy link
Copy Markdown
Contributor
  • Resolves: clicking Global Search breaks the sharing tab

Summary

  • Probably a regression from new flow: Improve sharing flow #39472
  • In the past, on select it (in addShare):
    1. Checked if it was not the lookup = global search option
    2. Checked if it was not the external with custom handler option
    3. Created a share with default params
  • Then it was moved to a new create share details view
    • onSelect now simply opens the details view where the share can be created
    • p.2 is also moved to the SharingDetails
    • p.1 was missed

TODO

  • Migrate to new built-in NcSelect label
    image
  • Remove old now unused addShare method
  • Restore lookup select processing

Screenshots

🏚️ Before🏡 After
global-search-sharing-beforeglobal-search-sharing-after

Checklist

@ShGKmeShGKme added this to the Nextcloud 30 milestone Jun 17, 2024
@ShGKmeShGKme self-assigned this Jun 17, 2024
@ShGKme
ShGKme marked this pull request as draft June 17, 2024 14:20
@ShGKmeShGKme changed the title fix(files_sharing ): global search in sharing tabfix(files_sharing): global search in sharing tabJun 17, 2024
@ShGKme
ShGKme marked this pull request as ready for review June 17, 2024 14:25
@ShGKme

Copy link
Copy Markdown
ContributorAuthor

/backport to stable29

@ShGKme

Copy link
Copy Markdown
ContributorAuthor

/backport to stable28

@ShGKme

Copy link
Copy Markdown
ContributorAuthor

/backport to stable27

Comment threadapps/files_sharing/src/components/SharingInput.vue Outdated
ShGKme added 4 commits June 21, 2024 12:31
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
ShGKmeforce-pushed the fix/files_sharing--global-search-in-select branch from 25d6e8a to 5b3830cCompareJune 21, 2024 11:45
@ShGKme

Copy link
Copy Markdown
ContributorAuthor

Rebased onto master to resolve conflict and removed unused return value true

@ShGKme
ShGKme enabled auto-merge June 21, 2024 11:46
<NcSelect ref="select"
v-model="value"
input-id="sharing-search-input"
:input-label="t('files_sharing', 'Search for share recipients')"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks cypress tests.
I agree we do not need the ID but then you need to change the selector in the Cypress tests.

@ShGKme
ShGKme marked this pull request as draft June 25, 2024 21:28
auto-merge was automatically disabled June 25, 2024 21:28

Pull request was converted to draft

@skjnldsvskjnldsv added the 2. developing Work in progress label Jul 27, 2024
@skjnldsvskjnldsv removed the 3. to review Waiting for reviews label Jul 27, 2024
@blizzzblizzz modified the milestones: Nextcloud 31, Nextcloud 32Jan 29, 2025
@blizzzblizzz modified the milestones: Nextcloud 33, Nextcloud 34Feb 16, 2026
@susnuxsusnux removed this from the Nextcloud 34.0.1 milestone Jun 9, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@ShGKme@susnux@Pytal@joshtrichards@blizzz@skjnldsv@nextcloud-bot