Skip to content

fix(CardDAV): set owner-principal, displayname properties for SAB - #39525

Merged
tcitworld merged 1 commit into
masterfrom
fix/set-owner-principal-for-SAB
Aug 16, 2023
Merged

fix(CardDAV): set owner-principal, displayname properties for SAB#39525
tcitworld merged 1 commit into
masterfrom
fix/set-owner-principal-for-SAB

Conversation

@miaulalala

@miaulalalamiaulalala commented Jul 21, 2023

Copy link
Copy Markdown
Contributor

Found in #38397

Summary

The SAB has no owner principal even though it is a "shared" address book - the system user shares it will all users automatically.

Checklist

@miaulalalamiaulalala added bug 3. to review Waiting for reviews feature: carddav Related to CardDAV internals labels Jul 21, 2023
@miaulalalamiaulalala added this to the Nextcloud 28 milestone Jul 21, 2023
@miaulalalamiaulalala self-assigned this Jul 21, 2023
@miaulalala

Copy link
Copy Markdown
ContributorAuthor

/backport to stable27

Comment threadapps/dav/lib/Connector/Sabre/Principal.php Outdated
Comment threadapps/dav/lib/Connector/Sabre/Principal.php Outdated
@tcitworld

Copy link
Copy Markdown
Member
1) OCA\DAV\Tests\unit\CardDAV\AddressBookTest::testPropPatchNotShared
Expectation failed for method name is "updateAddressBook" when invoked at least 1 times.
Expected invocation at least 1 times but it occurred 0 time(s).

@miaulalala
miaulalalaforce-pushed the fix/set-owner-principal-for-SAB branch from fb883bd to e7a11d0CompareJuly 25, 2023 14:50
@miaulalala
miaulalalaforce-pushed the fix/set-owner-principal-for-SAB branch from e7a11d0 to 1b77b03CompareJuly 26, 2023 16:03
@miaulalala
miaulalala enabled auto-merge July 26, 2023 16:04
@tcitworld
tcitworld disabled auto-merge July 26, 2023 20:03
@tcitworld
tcitworld enabled auto-merge July 26, 2023 20:03
@JohannesGGE
JohannesGGEforce-pushed the fix/set-owner-principal-for-SAB branch from 1b77b03 to 30a9303CompareAugust 8, 2023 19:08
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala
miaulalalaforce-pushed the fix/set-owner-principal-for-SAB branch from 30a9303 to 6bd7891CompareAugust 16, 2023 07:11
@tcitworld
tcitworld merged commit 6d0dabe into masterAug 16, 2023
@tcitworld
tcitworld deleted the fix/set-owner-principal-for-SAB branch August 16, 2023 08:17
@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugfeature: carddavRelated to CardDAV internals

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants

@miaulalala@tcitworld@ChristophWurst@JohannesGGE@skjnldsv