Skip to content

[stable27] fix(CardDAV): set owner-principal, displayname properties for SAB - #39900

Merged
skjnldsv merged 1 commit into
stable27from
fix/stable27/set-owner-principal-for-SAB
Aug 25, 2023
Merged

[stable27] fix(CardDAV): set owner-principal, displayname properties for SAB#39900
skjnldsv merged 1 commit into
stable27from
fix/stable27/set-owner-principal-for-SAB

Conversation

@miaulalala

@miaulalalamiaulalala commented Aug 16, 2023

Copy link
Copy Markdown
Contributor

Manual backport of #39525

@miaulalalamiaulalala added bug 3. to review Waiting for reviews labels Aug 16, 2023
@miaulalalamiaulalala added this to the Nextcloud 27.1.0 milestone Aug 16, 2023
@miaulalalamiaulalala self-assigned this Aug 16, 2023
@miaulalala

miaulalala commented Aug 16, 2023

Copy link
Copy Markdown
ContributorAuthor

Not sure if this is missing a backport for the authentication fix? cc @JohannesGGE

@JohannesGGE

JohannesGGE commented Aug 16, 2023

Copy link
Copy Markdown
Contributor

#38397 got in on 18th July (2 days before 27.0.1). So I'm not sure as well, if we have to backport here. 😅
@ChristophWurst

@miaulalala

miaulalala commented Aug 16, 2023

Copy link
Copy Markdown
ContributorAuthor

looks like this was after branch off to stable27 then. Backport it is 🙂

@miaulalala

miaulalala commented Aug 16, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@skjnldsvskjnldsv mentioned this pull request Aug 16, 2023
Merged
7 tasks
@miaulalala
miaulalalaforce-pushed the fix/stable27/set-owner-principal-for-SAB branch from 3c3b2f8 to fdce28dCompareAugust 17, 2023 07:46
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 17, 2023
@skjnldsv

skjnldsv commented Aug 17, 2023

Copy link
Copy Markdown
Member
There was 1 failure:
295 | 296 | 1) OCA\DAV\Tests\unit\CardDAV\AddressBookTest::testPropPatchShared
297 | OCA\DAV\CardDAV\CardDavBackend::updateAddressBook(666, Sabre\DAV\PropPatch Object (...)) was not expected to be called.
298 | 299 | /drone/src/3rdparty/sabre/dav/lib/CardDAV/AddressBook.php:184
300 | /drone/src/apps/dav/lib/CardDAV/AddressBook.php:230
301 | /drone/src/apps/dav/tests/unit/CardDAV/AddressBookTest.php:118

@miaulalala
miaulalalaforce-pushed the fix/stable27/set-owner-principal-for-SAB branch from 88fd1df to b1cbedcCompareAugust 22, 2023 08:44
@skjnldsvskjnldsv mentioned this pull request Aug 24, 2023
Merged
4 tasks
@skjnldsv
skjnldsvforce-pushed the fix/stable27/set-owner-principal-for-SAB branch from b1cbedc to 5b5ce26CompareAugust 24, 2023 08:06
@miaulalala
fix(CardDAV): set owner-principal, displayname properties for SAB
504f396
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala
miaulalalaforce-pushed the fix/stable27/set-owner-principal-for-SAB branch from 5b5ce26 to 504f396CompareAugust 24, 2023 13:07
@skjnldsv
skjnldsv merged commit 146cc6a into stable27Aug 25, 2023
@skjnldsv
skjnldsv deleted the fix/stable27/set-owner-principal-for-SAB branch August 25, 2023 06:11
@blizzzblizzz mentioned this pull request Aug 29, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AltahrimAltahrimAltahrim approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurstChristophWurst is a code owner
@tcitworldtcitworldAwaiting requested review from tcitworldtcitworld is a code owner
@JohannesGGEJohannesGGEAwaiting requested review from JohannesGGE

Assignees

@miaulalalamiaulalala

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

💌 📅 👥 Groupware team
Archived in project

Milestone

Nextcloud 27.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@miaulalala@JohannesGGE@skjnldsv@Altahrim