Uh oh!
There was an error while loading. Please reload this page.
Move lib/ events to IEventDispatcher where possible - #39571
Merged
Conversation
nickvergessenforce-pushed
the
bugfix/noid/move-lib-to-IEventDispatcher
branch
from
July 25, 2023 17:41
457f1fd to
8fba3b4Compare| // notifications api to accept incoming user shares | ||
| $oldDispatcher->addListener('OCP\Share::postShare', function (OldGenericEvent $event) { | ||
| $dispatcher->addListener('OCP\Share::postShare', function ($event) { | ||
| if (!$event instanceof OldGenericEvent) { |
Check notice
Code scanning / Psalm
RedundantConditionGivenDocblockType
| }); | ||
| $oldDispatcher->addListener(IGroup::class . '::postAddUser', function (OldGenericEvent $event) { | ||
| $dispatcher->addListener(IGroup::class . '::postAddUser', function ($event) { | ||
| if (!$event instanceof OldGenericEvent) { |
Check notice
Code scanning / Psalm
RedundantConditionGivenDocblockType
| $userBackendRegisteredEvent = new UserBackendRegistered($userBackend, $userPluginManager); | ||
| $legacyDispatcher->dispatch('OCA\\User_LDAP\\User\\User::postLDAPBackendAdded', $userBackendRegisteredEvent); | ||
| $dispatcher->dispatch('OCA\\User_LDAP\\User\\User::postLDAPBackendAdded', $userBackendRegisteredEvent); |
Check notice
Code scanning / Psalm
DeprecatedMethod
| } | ||
| private function registerBackendDependents(IAppContainer $appContainer, EventDispatcherInterface $dispatcher) { | ||
| private function registerBackendDependents(IAppContainer $appContainer, IEventDispatcher $dispatcher) { |
Check notice
Code scanning / Psalm
MissingReturnType
| } | ||
| private function registerBackendDependents(IAppContainer $appContainer, EventDispatcherInterface $dispatcher) { | ||
| private function registerBackendDependents(IAppContainer $appContainer, IEventDispatcher $dispatcher) { |
Check notice
Code scanning / Psalm
DeprecatedInterface
nickvergessenforce-pushed
the
bugfix/noid/move-lib-to-IEventDispatcher
branch
from
July 26, 2023 06:38
8fba3b4 to
cd75dc0Comparest3iny
commented
Jul 26, 2023
Member
Code is too deep for me. PHP CS check is unhappy though. |
st3iny
removed their request for review
July 26, 2023 09:11
nickvergessenforce-pushed
the
bugfix/noid/move-lib-to-IEventDispatcher
branch
3 times, most recently
from
July 26, 2023 20:40
1193b43 to
978cef9Comparecome-nc
reviewed
Jul 27, 2023
come-nc
left a comment
Contributor
There was a problem hiding this comment.
Did you keep track of all removed legacy events to fill the upgrade documentation accordingly?
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
…itionalScripts Signed-off-by: Joas Schilling <coding@schilljs.com>
… Manager Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessenforce-pushed
the
bugfix/noid/move-lib-to-IEventDispatcher
branch
from
July 27, 2023 07:58
978cef9 to
35c313eCompareMemberAuthor
Yes, will send a PR once the last remaining events are migrated. Todo list is: And can also be rechecked with the links on #38546 (comment) afterwards |
come-nc
approved these changes
Jul 27, 2023
nickvergessen
enabled auto-merge
July 27, 2023 16:58
ChristophWurst
approved these changes
Jul 27, 2023
15 tasks
nickvergessen
commented
Jul 28, 2023
MemberAuthor
Docs in nextcloud/documentation#10858 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist