Uh oh!
There was an error while loading. Please reload this page.
fix(dispatcher): Move remaining simple cases in apps/ folder to IEven… - #39485
Merged
nickvergessen merged 1 commit intoJul 26, 2023
Merged
Conversation
| // notifications api to accept incoming user shares | ||
| $oldDispatcher->addListener('OCP\Share::postShare', function (OldGenericEvent $event) { | ||
| $dispatcher->addListener('OCP\Share::postShare', function ($event) { | ||
| if (!$event instanceof OldGenericEvent) { |
Check notice
Code scanning / Psalm
RedundantConditionGivenDocblockType
| }); | ||
| $oldDispatcher->addListener(IGroup::class . '::postAddUser', function (OldGenericEvent $event) { | ||
| $dispatcher->addListener(IGroup::class . '::postAddUser', function ($event) { | ||
| if (!$event instanceof OldGenericEvent) { |
Check notice
Code scanning / Psalm
RedundantConditionGivenDocblockType
| $userBackendRegisteredEvent = new UserBackendRegistered($userBackend, $userPluginManager); | ||
| $legacyDispatcher->dispatch('OCA\\User_LDAP\\User\\User::postLDAPBackendAdded', $userBackendRegisteredEvent); | ||
| $dispatcher->dispatch('OCA\\User_LDAP\\User\\User::postLDAPBackendAdded', $userBackendRegisteredEvent); |
Check notice
Code scanning / Psalm
DeprecatedMethod
| } | ||
| private function registerBackendDependents(IAppContainer $appContainer, EventDispatcherInterface $dispatcher) { | ||
| private function registerBackendDependents(IAppContainer $appContainer, IEventDispatcher $dispatcher) { |
Check notice
Code scanning / Psalm
MissingReturnType
| } | ||
| private function registerBackendDependents(IAppContainer $appContainer, EventDispatcherInterface $dispatcher) { | ||
| private function registerBackendDependents(IAppContainer $appContainer, IEventDispatcher $dispatcher) { |
Check notice
Code scanning / Psalm
DeprecatedInterface
nickvergessenforce-pushed
the
bugfix/noid/move-remaining-easy-usages-to-IEventDispatcher
branch
from
July 19, 2023 20:07
08ce53a to
f733301Comparecome-nc
approved these changes
Jul 20, 2023
…tDispatcher Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessenforce-pushed
the
bugfix/noid/move-remaining-easy-usages-to-IEventDispatcher
branch
from
July 25, 2023 09:19
f733301 to
77bc6c3Compare4 tasks
nickvergessen
requested review from
a team, ArtificialOwl, ChristophWurst and nfebe
and removed request for
a teamJuly 25, 2023 20:20
| $dispatcher->addListener('OCP\Share::postShare', function ($event) { | ||
| if (!$event instanceof OldGenericEvent) { | ||
| return; | ||
| } |
MemberAuthor
There was a problem hiding this comment.
It helps to trick psalm, so it doesn't yield on $listener->shareNotification($event) Later on, which only eats GenericEvent.
But it only is an intermediate step anyway to move forward to 5.4.x of the dispatcher. When we have to update to 6.4.x at the end of the year, GenericEvent will no longer exist and we need to do more work I guess, so I took the soft/low effort approach and added this mini guard.
marcelklehr
approved these changes
Jul 26, 2023
nickvergessen
deleted the
bugfix/noid/move-remaining-easy-usages-to-IEventDispatcher
branch
July 26, 2023 15:29
This was referenced Jul 27, 2023
nickvergessen
commented
Jul 28, 2023
MemberAuthor
Docs in nextcloud/documentation#10858 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tDispatcher
Checklist