Skip to content

fix!: Remove symfony EventDispatcherInterface from OC\User and OC\Group - #39595

Merged
nickvergessen merged 3 commits into
masterfrom
bugfix/noid/remove-symfony-event-from-user
Jul 28, 2023
Merged

fix!: Remove symfony EventDispatcherInterface from OC\User and OC\Group#39595
nickvergessen merged 3 commits into
masterfrom
bugfix/noid/remove-symfony-event-from-user

Conversation

@nickvergessen

@nickvergessennickvergessen commented Jul 27, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Checklist

@nickvergessennickvergessen added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 pending documentation This pull request needs an associated documentation update labels Jul 27, 2023
@nickvergessennickvergessen added this to the Nextcloud 28 milestone Jul 27, 2023
@nickvergessennickvergessen self-assigned this Jul 27, 2023
@nickvergessen
nickvergessen requested review from ArtificialOwl and nfebe and removed request for a teamJuly 27, 2023 17:02
@nickvergessen
nickvergessenforce-pushed the bugfix/noid/remove-symfony-event-from-user branch from e739f83 to f1cc66fCompareJuly 27, 2023 17:08
@nickvergessen
fix!: Remove symfony EventDispatcherInterface from User
ad12a74
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix!: Remove symfony EventDispatcherInterface from Group
80f79e1
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix: Align doc type with creation
030e8d8
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessenforce-pushed the bugfix/noid/remove-symfony-event-from-user branch from 359a6bb to 030e8d8CompareJuly 27, 2023 21:13
@nickvergessennickvergessen mentioned this pull request Jul 27, 2023
Merged
4 tasks
@nickvergessen
nickvergessen merged commit f3bdcfd into masterJul 28, 2023
@nickvergessen
nickvergessen deleted the bugfix/noid/remove-symfony-event-from-user branch July 28, 2023 08:40
@nickvergessennickvergessen mentioned this pull request Jul 28, 2023
Merged
15 tasks
@nickvergessennickvergessen removed the pending documentation This pull request needs an associated documentation update label Jul 28, 2023
@nickvergessen

nickvergessen commented Jul 28, 2023

Copy link
Copy Markdown
MemberAuthor

Docs in nextcloud/documentation#10858

@nickvergessennickvergessen mentioned this pull request Jul 31, 2023
Closed
@juliusknorrjuliusknorr mentioned this pull request Aug 7, 2023
Closed
@skjnldsvskjnldsv mentioned this pull request Aug 11, 2023
Closed
@gino0631gino0631 mentioned this pull request Dec 13, 2023
Closed
@illnesse

illnesse commented Dec 29, 2023

Copy link
Copy Markdown

any idea how to stop the metadata app from spamming the log with "Call to undefined method OC\Server::getEventDispatcher()" errors? is that something that needs fixing in the app?

@come-nc

come-nc commented Jan 2, 2024

Copy link
Copy Markdown
Contributor

any idea how to stop the metadata app from spamming the log with "Call to undefined method OC\Server::getEventDispatcher()" errors? is that something that needs fixing in the app?

Yes, the app is not yet released for 28.
See gino0631/nextcloud-metadata#106

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@nfebenfebenfebe approved these changes
@julien-ncjulien-ncAwaiting requested review from julien-nc
@come-nccome-ncAwaiting requested review from come-nc
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

Assignees

@nickvergessennickvergessen

Labels

3. to reviewWaiting for reviewstechnical debt🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

5 participants

@nickvergessen@illnesse@come-nc@ChristophWurst@nfebe