Uh oh!
There was an error while loading. Please reload this page.
fix!: Final round of moving to IEventDispatcher - #39605
Merged
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
nickvergessenforce-pushed
the
bugfix/noid/final-events-cleanup
branch
from
July 28, 2023 08:45
30b5d64 to
f9b3e16Comparenickvergessen
requested review from
a team, ChristophWurst, come-nc, icewind1991, kesselb and nfebe
and removed request for
a teamJuly 28, 2023 08:45
15 tasks
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessenforce-pushed
the
bugfix/noid/final-events-cleanup
branch
from
July 28, 2023 12:11
f9b3e16 to
3962cd0Compare| static $eventSent = false; | ||
| if (!$eventSent) { | ||
| \OC::$server->getEventDispatcher()->dispatch( | ||
| \OC::$server->get(IEventDispatcher::class)->dispatch( |
Check notice
Code scanning / Psalm
DeprecatedMethod
come-nc
approved these changes
Jul 31, 2023
Uh oh!
There was an error while loading. Please reload this page.
Altahrim
approved these changes
Aug 4, 2023
Comment on lines
+124
to
+128
| if ($addToFavorite) { | ||
| $event = new NodeAddedToFavorite($user, $fileId, $path); | ||
| } else { | ||
| $event = new NodeRemovedFromFavorite($user, $fileId, $path); | ||
| } |
Collaborator
There was a problem hiding this comment.
Nit:
$event = $addToFavorite
? newNodeAddedToFavorite($user, $fileId, $path);
: newNodeRemovedFromFavorite($user, $fileId, $path);MemberAuthor
There was a problem hiding this comment.
Not a fan of inline-if when generating objects 🙈
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist