Uh oh!
There was an error while loading. Please reload this page.
Add endpoint for getting disabled user list - #39756
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
provokateurin
commented
Aug 18, 2023
There is a new CI workflow that checks that the OpenAPI specs are up-to-date. Please rebase onto master and regenerate the specs so that the workflow can do it's job. |
0833802 to
fa1f37cCompare303c153 to
4d63760Comparebc0fcbe to
93722e7CompareSigned-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
93722e7 to
61da2b9CompareSigned-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
nfebe
left a comment
There was a problem hiding this comment.
A default value for limit seems reasonable of if null, we should check for valid values different from zero... Such as negative numbers and 0
if ($limit !== null && $limit < 0) {
// Whatever exceptionthrownewInvalidArgumentException("Invalid limit value: $limit");
}
if ($offset < 0) {
thrownewInvalidArgumentException("Invalid offset value: $offset");
}Generally, this is a little slim or error handling.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
commented
Oct 10, 2023
Nice input, I’ve added that to the controller method. |
Summary
Adds an endpoint to get the list of disabled users, with offset and limit.
This avoids fetching all the users when opening the disabled user list, fixing the disabled user list for LDAP backed installations which do not have a lot of disabled users. Also avoids spamming the LDAP server when opening disabled user list.
TODO
Checklist