Skip to content

enh(settings): Load from disabled users endpoint - #40169

Merged
Pytal merged 3 commits into
masterfrom
enh/load-disabled-users-directly
Dec 1, 2023
Merged

enh(settings): Load from disabled users endpoint#40169
Pytal merged 3 commits into
masterfrom
enh/load-disabled-users-directly

Conversation

@Pytal

@PytalPytal commented Aug 31, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Summary

  • Load users directly from disabled users endpoint

Checklist

@PytalPytal added the 2. developing Work in progress label Aug 31, 2023
@PytalPytal self-assigned this Aug 31, 2023
@Pytal
Pytalforce-pushed the enh/add-disabled-users-endpoint branch from 303c153 to 4d63760CompareSeptember 9, 2023 00:13
@Pytal
Pytalforce-pushed the enh/load-disabled-users-directly branch from f0adf49 to 12ce9daCompareSeptember 9, 2023 00:38
@PytalPytal changed the title [WIP] enh(settings): Load from disabled users endpointenh(settings): Load from disabled users endpointSep 9, 2023
@Pytal
Pytal marked this pull request as ready for review September 9, 2023 00:39
@PytalPytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 9, 2023
@PytalPytal added this to the Nextcloud 28 milestone Sep 9, 2023
come-nc

This comment was marked as resolved.

Sign in to view

@come-nc
come-ncforce-pushed the enh/add-disabled-users-endpoint branch from 4d63760 to bc0fcbeCompareSeptember 12, 2023 07:08
@Pytal
Pytalforce-pushed the enh/load-disabled-users-directly branch from 12ce9da to d690221CompareSeptember 12, 2023 23:10
@come-nc
come-ncforce-pushed the enh/add-disabled-users-endpoint branch from bc0fcbe to 93722e7CompareSeptember 18, 2023 13:33
@Pytal
Pytalforce-pushed the enh/load-disabled-users-directly branch from d690221 to c8acf37CompareSeptember 29, 2023 18:52
@provokateurin
provokateurin removed their request for review September 29, 2023 18:54
come-nc
come-nc reviewed Oct 2, 2023
View reviewed changes
Comment threadapps/settings/src/components/UserList.vue Outdated
@Pytal
Pytal requested a review from artongeOctober 5, 2023 16:20
@come-nc

This comment was marked as resolved.

Sign in to view
@come-nc
come-ncforce-pushed the enh/add-disabled-users-endpoint branch from 93722e7 to 61da2b9CompareOctober 9, 2023 10:04
@come-nccome-nc mentioned this pull request Oct 9, 2023
Merged
5 tasks
Base automatically changed from enh/add-disabled-users-endpoint to masterOctober 10, 2023 11:33
@Pytal
Pytalforce-pushed the enh/load-disabled-users-directly branch from c8acf37 to 716c8b2CompareOctober 16, 2023 22:56
@come-nc

This comment was marked as resolved.

Sign in to view
@skjnldsvskjnldsv mentioned this pull request Nov 1, 2023
Merged
@blizzzblizzz mentioned this pull request Nov 6, 2023
Merged
@PytalPytal mentioned this pull request Nov 8, 2023
Closed
@PytalPytal linked an issue Nov 8, 2023 that may be closed by this pull request
Disabled users tab not working unless searching #41342
Closed
@blizzzblizzz mentioned this pull request Nov 10, 2023
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzzblizzz modified the milestones: Nextcloud 28, Nextcloud 29Nov 23, 2023
@Pytal
Pytalforce-pushed the enh/load-disabled-users-directly branch 2 times, most recently from c0a3f40 to 822ba99CompareNovember 28, 2023 19:23
@Pytal
Pytalforce-pushed the enh/load-disabled-users-directly branch from 822ba99 to 85e7887CompareDecember 1, 2023 00:02
@Pytal

Pytal commented Dec 1, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to stable28

@PytalPytal added 4. to release Ready to be released and/or waiting for tests to finish feature: users and groups bug and removed 3. to review Waiting for reviews labels Dec 1, 2023
@PytalPytal mentioned this pull request Dec 1, 2023
Merged
@Pytal
Pytal enabled auto-merge December 1, 2023 00:40
@Pytal
Pytal disabled auto-merge December 1, 2023 00:40
Pytaland others added 3 commits November 30, 2023 17:15
@Pytal
enh(settings): Load from disabled users endpoint
f9bd957
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore: compile assets
ceca099
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@come-nc@Pytal
Invert parameter order in getDisabledUserList to be consistent
adc43ea
This matches what was done in the calls and so fixes getting disabled
user list when there are several backends returning disabled users.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@Pytal
Pytalforce-pushed the enh/load-disabled-users-directly branch from 85e7887 to adc43eaCompareDecember 1, 2023 01:15
@Pytal
Pytal merged commit 2943304 into masterDec 1, 2023
@Pytal
Pytal deleted the enh/load-disabled-users-directly branch December 1, 2023 16:42
@blizzzblizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnuxsusnuxsusnux approved these changes
@artongeartongeartonge approved these changes
@come-nccome-nccome-nc approved these changes

Assignees

@PytalPytal

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: users and groups

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

Disabled users tab not working unless searching

6 participants

@Pytal@come-nc@susnux@artonge@blizzz@skjnldsv