Uh oh!
There was an error while loading. Please reload this page.
fix: Also cleanup version metadata if expiring - #39786
Merged
Merged
Conversation
juliusknorr
requested review from
a team, ArtificialOwl, artonge, icewind1991 and nfebe
and removed request for
a teamAugust 10, 2023 07:29
Uh oh!
There was an error while loading. Please reload this page.
juliusknorrforce-pushed
the
bugfix/version-expire-cleanup
branch
from
August 10, 2023 07:31
26c7cda to
e3bdb72Comparejuliusknorr
commented
Aug 10, 2023
MemberAuthor
/backport to stable27 |
juliusknorr
commented
Aug 10, 2023
MemberAuthor
/backport to stable26 |
Merged
8 tasks
juliusknorr
commented
Aug 10, 2023
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorrforce-pushed
the
bugfix/version-expire-cleanup
branch
from
August 14, 2023 17:31
e3bdb72 to
bbb7172Compareartonge
approved these changes
Aug 14, 2023
icewind1991
approved these changes
Aug 14, 2023
This was referenced Aug 14, 2023
solracsf
commented
Aug 15, 2023
Member
@juliushaertl no 25 ? |
juliusknorr
commented
Aug 15, 2023
MemberAuthor
Only 26+ is affected where the new table for metadata was introduced |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while writing e2e tests for #39140
Steps to reproduce:
server/apps/files_versions/lib/Storage.php
Lines 87 to 100 in 26c7cda
This leads to the version files being deleted while the oc_files_versions table still contains references, meaning that they show up as broken files in the versions sidebar.
Ideally expiration should also be handled by the version manager, but this requires some larger efforts and is not backportable.
Quick script to reproduce:
Afterwards you can compare the following sql queries before and after cron for validation:
Checklist