Skip to content

Cypress tests for smart picker, code block, mermaid and version view/compare - #4663

Merged
juliusknorr merged 6 commits into
mainfrom
tests/cypress-hub6
Aug 30, 2023
Merged

Cypress tests for smart picker, code block, mermaid and version view/compare#4663
juliusknorr merged 6 commits into
mainfrom
tests/cypress-hub6

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Aug 9, 2023

Copy link
Copy Markdown
Member
  • tests(cypress): Add smartpicker tests
  • tests(cypress): Add code block and mermaid tests
  • tests(cypress): Add version view and compare tests

🚧 TODO

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@cypress

cypressBot commented Aug 9, 2023

Copy link
Copy Markdown

2 flaky tests on run #11926 ↗︎

0143180Flakiness2

Details:

Cypress tests for smart picker, code block, mermaid and version view/compare
Project: TextCommit:869f8e25ad
Status: PassedDuration: 06:54 💡
Started: Aug 30, 2023 9:09 AMEnded: Aug 30, 2023 9:16 AM
Flakiness shortcuts.spec.js • 1 flaky test

ViewOutputVideo

Test Artifacts
keyboard shortcuts > unordered-list OutputScreenshots
Flakiness api/SyncServiceProvider.spec.js • 1 flaky test

ViewOutputVideo

Test Artifacts
Sync service provider > recovers from a dropped message OutputScreenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorr
juliusknorrforce-pushed the tests/cypress-hub6 branch 2 times, most recently from 48a4bcf to 7b4be33CompareAugust 10, 2023 12:17
@juliusknorr
juliusknorr marked this pull request as ready for review August 10, 2023 12:20
@juliusknorrjuliusknorr added tests If you write them we ♥ you 3. to review labels Aug 10, 2023
@juliusknorrjuliusknorr changed the title tests/cypress hub6Cypress tests for smart picker, code block, mermaid and version view/compareAug 10, 2023
@juliusknorrjuliusknorr added this to the Nextcloud 28 milestone Aug 10, 2023
@juliusknorr
juliusknorrforce-pushed the tests/cypress-hub6 branch 2 times, most recently from e7c0508 to e00b4b1CompareAugust 14, 2023 07:46
@juliusknorrjuliusknorr mentioned this pull request Aug 24, 2023
4 tasks

@max-nextcloudmax-nextcloud left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Two .only need to be removed still. Approving anyway so you can move on afterwards.

Comment on lines +29 to +30
expect('To-Do list').to.be.oneOf(entries)
expect('Table').to.be.oneOf(entries)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still expected after the recent reordering that put default actions on top again?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine for the test as there is only very limited default pickers. Will check though.

Comment threadcypress/e2e/SmartPicker.spec.js Outdated
Comment threadcypress/e2e/nodes/CodeBlock.spec.js Outdated
Comment threadcypress/support/e2e.js
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

Okay, needs some more fixing I guess

@juliusknorr
juliusknorrforce-pushed the tests/cypress-hub6 branch 2 times, most recently from cf8588a to 59d9f0cCompareAugust 29, 2023 19:01
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

Ok, new failure due to the nextcloud-vue update that changed the label position

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
juliusknorr merged commit 7394da2 into mainAug 30, 2023
@juliusknorr
juliusknorr deleted the tests/cypress-hub6 branch August 30, 2023 09:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releasetestsIf you write them we ♥ you

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@juliusknorr@max-nextcloud