Skip to content

reuse l10n and request in dav folder listing - #39864

Merged
icewind1991 merged 1 commit into
masterfrom
dav-reuse-request
Sep 4, 2023
Merged

reuse l10n and request in dav folder listing#39864
icewind1991 merged 1 commit into
masterfrom
dav-reuse-request

Conversation

@icewind1991

Copy link
Copy Markdown
Member

instead of having to query those once for every node

saved 15-20% when loading large folders during local testing: https://blackfire.io/profiles/compare/d33a9993-e3a4-4ea4-b9f2-f1b38f576937/graph

@icewind1991icewind1991 added the 3. to review Waiting for reviews label Aug 14, 2023
@icewind1991icewind1991 added this to the Nextcloud 28 milestone Aug 14, 2023
@icewind1991
icewind1991 requested review from a team, ArtificialOwl, blizzz and nfebe and removed request for a teamAugust 14, 2023 14:13
Comment threadapps/dav/lib/Connector/Sabre/Directory.php Fixed
@icewind1991
icewind1991force-pushed the dav-reuse-request branch 4 times, most recently from b6d4bb9 to 30209eaCompareAugust 15, 2023 13:51
Comment threadapps/dav/lib/Connector/Sabre/Directory.php Outdated
Comment threadapps/dav/tests/unit/Connector/Sabre/RequestTest/Sapi.php Outdated
@icewind1991

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

Comment threadapps/dav/lib/Connector/Sabre/Directory.php Outdated
instead of having to query those once for every node
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
icewind1991 merged commit 9053eea into masterSep 4, 2023
@icewind1991
icewind1991 deleted the dav-reuse-request branch September 4, 2023 13:57
@icewind1991

Copy link
Copy Markdown
MemberAuthor

/backport to stable26

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@icewind1991

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsperformance 🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@icewind1991@nickvergessen@skjnldsv@github-advanced-security