fix(CardDAV): allow disabling of the system address book

[miaulalala]

via config option and OCC command

• Resolves: Provide a way to hide / remove the system address book globally #38880

Summary

Allow admins to disable the System Addressbook systemwide.

This might cause complaints from connected clients if the SAB is the default addressbook in their env.

TODO

• Documentation

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[ChristophWurst]

config:app:set/delete should be sufficient. we don't need dedicated commands right now: https://docs.nextcloud.com/server/stable/admin_manual/configuration_server/occ_command.html#config-commands

[miaulalala]

/backport to stable27

[tcitworld]

I feel like just adding an if to the above block where the system address book is added in the first place would be much more efficient, why not do that instead?

(in any case, you need to get the getAppValue call outside of the array_map so that it doesn't get called for each iteration)

[tcitworld]

Code is fine but I didn't check if that has other consequences elsewhere.

[miaulalala]

Failing cypress test is unrelated methinks:

 Login with a new user and open the files app
1) "after all" hook for "See the default file welcome.txt in the files list"
0 passing (7s)
1 failing
1) Login with a new user and open the files app
"after all" hook for "See the default file welcome.txt in the files list":
CypressError: The following error originated from your application code, not from Cypress. It was caused by an unhandled promise rejection.

[mbiebl]

Applied this patch and everything is working nicely again after disabling the SAB. Thanks a lot!

[sudoer]

I was able to comment out this block of code, and I saw that the "Accounts" address book was no longer exported, as we had hoped. So I am looking forward to the configuration-based fix soon.

I did have a question. When this pull request is merged, how would someone set the configuration option? Is it in a config file? Or is there an "occ" command to set the option? Is it eventually stored in the database, or in the code? I imagine this question is a bit outside of the scope of this PR, but it sure would help to have a pointer to how to enable/disable it. Thanks!

[tcitworld]

php occ config:app:set dav system_addressbook_exposed --value=no

[MicKress]

Hi, I have a question. Will the deactivation of system address book only be possible via occ-Command or will there be an point in the administration panel? If you have a managed nextcloud, you cannot often work with occ-commands. Best Regards

[exuded]

Hello, when using the command given in the documentation, I get the following error:

I am a bit confused because in the command is no "-a" part

[tcitworld]

@exuded Please ask for help on the forum or open your own issue.