Skip to content

[stable27] fix(CardDAV): allow disabling of the system address book - #40200

Merged
blizzz merged 1 commit into
stable27from
backport/39925/stable27
Sep 6, 2023
Merged

[stable27] fix(CardDAV): allow disabling of the system address book #40200
blizzz merged 1 commit into
stable27from
backport/39925/stable27

Conversation

@backportbot-nextcloud

Copy link
Copy Markdown

Backport of #39925

@st3inyst3iny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block merges during freezes / Block merges during freezes (pull_request)

😢

…ption
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala
miaulalalaforce-pushed the backport/39925/stable27 branch from e7006fb to 6354dceCompareSeptember 5, 2023 08:22
@skjnldsv

Copy link
Copy Markdown
Member

@blizzz can we merge?

@AndyScherzinger

Copy link
Copy Markdown
Member

Since there are several positive testers' feedback in, see #39925 (comment) I would say, fine to merge even though post-RC1

@skjnldsvskjnldsv added the 4. to release Ready to be released and/or waiting for tests to finish label Sep 5, 2023
@miaulalala

Copy link
Copy Markdown
Contributor

PHPUnit fails with:

 [InvalidArgumentException] Database <oci> is not supported. sqlite, mysql, pgsql are supported. 

@blizzzblizzz mentioned this pull request Sep 5, 2023
6 tasks
@blizzz

Copy link
Copy Markdown
Member

PHPUnit fails with:

 [InvalidArgumentException] Database <oci> is not supported. sqlite, mysql, pgsql are supported. 

Was a hiccup only

@blizzz
blizzz merged commit b956f0f into stable27Sep 6, 2023
@blizzz
blizzz deleted the backport/39925/stable27 branch September 6, 2023 08:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finish27-feedbackbugfeature: carddavRelated to CardDAV internals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@skjnldsv@AndyScherzinger@miaulalala@blizzz@ChristophWurst@st3iny