Uh oh!
There was an error while loading. Please reload this page.
fix: Avoid throwing on folder previews as there are none - #39950
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
juliusknorrforce-pushed
the
bugfix/uncaught-preview-promise
branch
from
August 18, 2023 07:39
033cd6f to
08360b9Compare10 tasks
juliusknorrforce-pushed
the
bugfix/uncaught-preview-promise
branch
from
August 21, 2023 15:26
08360b9 to
9c4e8a2Comparejuliusknorr
requested review from
luka-nextcloud, max-nextcloud, skjnldsv and susnuxAugust 21, 2023 15:26
juliusknorr
marked this pull request as ready for review
August 21, 2023 15:27
skjnldsv
approved these changes
Aug 22, 2023
max-nextcloud
approved these changes
Aug 22, 2023
skjnldsvforce-pushed
the
bugfix/uncaught-preview-promise
branch
from
August 22, 2023 08:37
9c4e8a2 to
f4adb0dCompareskjnldsv
commented
Aug 22, 2023
Member
/compile amend / |
Signed-off-by: Julius Härtl <jus@bitgrid.net> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-commandforce-pushed
the
bugfix/uncaught-preview-promise
branch
from
August 22, 2023 08:49
f4adb0d to
79c240aCompare1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise there is an uncaught exception thrown which blocks cypress tests in text.