Uh oh!
There was an error while loading. Please reload this page.
feat: 28 Files2vue compatibility - #4666
Merged
Merged
Conversation
Comment on lines
+52
to
+57
| webpackConfig.plugins.push(new webpack.ProvidePlugin({ | ||
| Buffer: ['buffer', 'Buffer'], | ||
| })) | ||
| webpackConfig.resolve.fallback = { | ||
| buffer: require.resolve('buffer'), | ||
| } |
MemberAuthor
There was a problem hiding this comment.
No clue, but it's required somehow
ref nextcloud-libraries/webpack-vue-config#450 (comment)
juliusknorr
commented
Aug 18, 2023
Member
Will take over for finishing tests and adjusting cypress to work with the f2v merge |
juliusknorrforce-pushed
the
feat/28-files
branch
from
August 18, 2023 05:13
c5495b0 to
e9b3ff9Comparejuliusknorrforce-pushed
the
feat/28-files
branch
from
August 18, 2023 07:40
5090f44 to
5ca136bCompare1 task
skjnldsv
commented
Aug 18, 2023
Uh oh!
There was an error while loading. Please reload this page.
max-nextcloudforce-pushed
the
feat/28-files
branch
from
August 21, 2023 14:52
52013d6 to
335d67bCompareUh oh!
There was an error while loading. Please reload this page.
juliusknorrforce-pushed
the
feat/28-files
branch
from
August 24, 2023 08:40
cf0c465 to
1725bdeCompareSigned-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Max <max@nextcloud.com>
File names are now rendered in two spans which breaks the assertion that the row contains `test.md`. But that is nothing text should worry about anyway. Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
max-nextcloudforce-pushed
the
feat/28-files
branch
from
August 27, 2023 08:41
1725bde to
96523ebComparemax-nextcloud
commented
Aug 27, 2023
Collaborator
/compile |
Collaborator
cypress tests that failed on the last run succeeded for me locally. 🤷 Failure was introduced later in server master branch. |
max-nextcloudforce-pushed
the
feat/28-files
branch
2 times, most recently
from
August 27, 2023 14:37
38094e1 to
140143eComparemax-nextcloudforce-pushed
the
feat/28-files
branch
from
August 27, 2023 14:57
140143e to
cf725faCompareSigned-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Max <max@nextcloud.com>
max-nextcloudforce-pushed
the
feat/28-files
branch
4 times, most recently
from
August 27, 2023 18:53
904ffa8 to
542ddbbCompareSee also nextcloud/server#40065 Signed-off-by: Max <max@nextcloud.com>
basename and extension are now split. Signed-off-by: Max <max@nextcloud.com>
max-nextcloudforce-pushed
the
feat/28-files
branch
from
August 27, 2023 19:01
542ddbb to
0a3705eComparemax-nextcloud
commented
Aug 27, 2023
Collaborator
/compile |
max-nextcloud
enabled auto-merge
August 27, 2023 19:11
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
max-nextcloud
commented
Aug 27, 2023
Collaborator
Follow up ticket:
|
max-nextcloud
approved these changes
Aug 27, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nextcloud/server#39808
Fixes#4626
@nextcloud/dialogsand use it by default server#39792 is merged/F2V final overview https://github.com/nextcloud/server/issues/39914