Uh oh!
There was an error while loading. Please reload this page.
fix(CalDAV): check birthday calendar owner - #40292
Merged
Merged
Conversation
miaulalala
commented
Sep 6, 2023
ContributorAuthor
/backport to stable27 |
miaulalala
commented
Sep 6, 2023
ContributorAuthor
/backport to stable26 |
miaulalala
commented
Sep 6, 2023
ContributorAuthor
/backport to stable25 |
miaulalalaforce-pushed
the
fix/birthday-calendar
branch
from
September 6, 2023 12:50
918d9b1 to
aa19033Comparebigcat88
approved these changes
Sep 6, 2023
miaulalala
commented
Sep 6, 2023
ContributorAuthor
/backport to stable24 |
miaulalala
commented
Sep 6, 2023
ContributorAuthor
/backport to stable23 |
| $this->server->addPlugin(new \OCA\DAV\CalDAV\BirthdayCalendar\EnablePlugin( | ||
| \OC::$server->getConfig(), | ||
| \OC::$server->query(BirthdayService::class) | ||
| \OC::$server->query(BirthdayService::class), |
Check notice
Code scanning / Psalm
DeprecatedMethod
miaulalala
commented
Sep 6, 2023
ContributorAuthor
/backport to stable22 |
provokateurin
approved these changes
Sep 6, 2023
Altahrim
approved these changes
Sep 6, 2023
This comment was marked as resolved.
This comment was marked as resolved.
tcitworld
approved these changes
Sep 6, 2023
tcitworld
left a comment
Member
There was a problem hiding this comment.
Okay, but shouldn't the CalendarHome's owner be the only one to be able to POST on it anyway?
AndyScherzinger
approved these changes
Sep 6, 2023
Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalalaforce-pushed
the
fix/birthday-calendar
branch
from
September 6, 2023 14:57
aa19033 to
7eee1deCompare
This was referenced Sep 6, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Sep 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the correct 403 response for the DAV endpoint
Checklist