Skip to content

[stable23] fix(CalDAV): check birthday calendar owner - #40318

Merged
blizzz merged 1 commit into
stable23from
backport/40292/stable23
Sep 7, 2023
Merged

[stable23] fix(CalDAV): check birthday calendar owner#40318
blizzz merged 1 commit into
stable23from
backport/40292/stable23

Conversation

@miaulalala

@miaulalalamiaulalala commented Sep 7, 2023

Copy link
Copy Markdown
Contributor

Manual backport of #40292

@miaulalala
fix(CalDAV): check birthday calendar owner
eca4fe4
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalalamiaulalala added bug 3. to review Waiting for reviews labels Sep 7, 2023
@miaulalalamiaulalala self-assigned this Sep 7, 2023
@miaulalala
miaulalala requested review from ArtificialOwl, come-nc and sorbaugh and removed request for a teamSeptember 7, 2023 06:43
@miaulalala

miaulalala commented Sep 7, 2023

Copy link
Copy Markdown
ContributorAuthor

Static Analysis failing because

Error: lib/private/Memcache/Memcached.php:70:8: TypeDoesNotContainType: Operand of type 0 is always false (see https://psalm.dev/056)

@miaulalalamiaulalala added 4. to release Ready to be released and/or waiting for tests to finish 3. to review Waiting for reviews and removed 3. to review Waiting for reviews 4. to release Ready to be released and/or waiting for tests to finish labels Sep 7, 2023
@blizzz

blizzz commented Sep 7, 2023

Copy link
Copy Markdown
Member

Static Analysis failing because

Error: lib/private/Memcache/Memcached.php:70:8: TypeDoesNotContainType: Operand of type 0 is always false (see https://psalm.dev/056)

Mh, but that's unrelated code. Maybe should check this with stable24, e.g., but that is outside your scope.

@miaulalalamiaulalala mentioned this pull request Sep 7, 2023
Merged
@blizzz
blizzz merged commit c20b2ce into stable23Sep 7, 2023
@blizzz
blizzz deleted the backport/40292/stable23 branch September 7, 2023 13:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bigcat88bigcat88bigcat88 approved these changes
@andrey18106andrey18106andrey18106 approved these changes
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
@tcitworldtcitworldAwaiting requested review from tcitworld
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl was automatically assigned from nextcloud/server-backend
@sorbaughsorbaughAwaiting requested review from sorbaughsorbaugh was automatically assigned from nextcloud/server-backend
@come-nccome-ncAwaiting requested review from come-nccome-nc was automatically assigned from nextcloud/server-backend

Assignees

@miaulalalamiaulalala

Labels

3. to reviewWaiting for reviewsbug

Projects

💌 📅 👥 Groupware team
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miaulalala@blizzz@bigcat88@andrey18106