Uh oh!
There was an error while loading. Please reload this page.
Fix invite guest for new sharing flow - #40389
Conversation
901f95f to
0f94c99Compare0f94c99 to
3d3fa76Comparenfebe
commented
Sep 13, 2023
/compile amend / |
AndyScherzinger
commented
Sep 13, 2023
Important point here is the backport then, which from what I understood will differ from the main branch one. |
3d3fa76 to
7474a9bComparenfebe
commented
Sep 13, 2023
/backport to stable27 |
nfebe
commented
Sep 13, 2023
I did this on stable27 and realized it would work on master so decide to send the PR here at once, would backport to stable27 from this. (If your comment is related to this) |
blizzz
commented
Sep 13, 2023
conflicts and red cypress |
0ec31ed to
00fdea4Comparenfebe
commented
Sep 13, 2023
/compile amend / |
00fdea4 to
171b921Comparenfebe
commented
Sep 14, 2023
/compile amend / |
171b921 to
6257c51Compare6257c51 to
419eb0dCompare419eb0d to
694f990CompareCall external handlers such as the one in the guess app https://github.com/nextcloud/guests/blob/master/src/main.js#L30 if present. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
694f990 to
1f74c88Comparenfebe
commented
Sep 14, 2023
/compile amend / |
1f74c88 to
7b0099fCompare7b0099f to
d3f2212Comparenfebe
commented
Sep 14, 2023
nfebe
commented
Sep 14, 2023
/compile amend / |
artonge
commented
Sep 14, 2023
This commit will need to be backported as well, as the rest is already merged into stable27 |
nfebe
commented
Sep 14, 2023
Exactly! already did :) |
d3f2212 to
84609d6Compare25a4037 to
7c4248fComparenfebe
commented
Sep 14, 2023
/compile amend / |
SharingEntryLink and regular ShareEntry were not properly visually aligned before this commit. Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
7c4248f to
2755976CompareAndyScherzinger
commented
Sep 14, 2023
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
nfebe
commented
Sep 14, 2023
It went in via this backport : #40415 thanks to @artonge the only thing that didn't go with that is the alignment commit which is non critical and is already back-ported now too. cc: @AndyScherzinger |
AndyScherzinger
commented
Sep 14, 2023
The backport et alignment we will probably need to dig in a bit deeper so it is also aligned with related resources (if present). So I expect the alignment will see a further small update. Do you happen to have a screenshot with shares and related resources? |


Resolves : #40172
Resolves : #40299