Skip to content

[stable27] Fix alignments for share different share entry types. - #40429

Merged
nfebe merged 1 commit into
stable27from
manual/backport/stable27/commit-in/40389
Sep 20, 2023
Merged

[stable27] Fix alignments for share different share entry types.#40429
nfebe merged 1 commit into
stable27from
manual/backport/stable27/commit-in/40389

Conversation

@nfebe

@nfebenfebe commented Sep 14, 2023

Copy link
Copy Markdown
Contributor

Backport commit in #40389

BeforeNow
Screenshot from 2023-09-14 14-46-42Screenshot from 2023-09-14 15-37-15

@nfebenfebe added 3. to review Waiting for reviews 27-feedback labels Sep 14, 2023
@AndyScherzingerAndyScherzinger added this to the Nextcloud 27.1.1 milestone Sep 14, 2023
@AndyScherzinger

AndyScherzinger commented Sep 14, 2023

Copy link
Copy Markdown
Member

@fenn-cs can we align the other share type on the one with the status, so things don't feel so "squeezed". I can post a example later today.

@nfebe

nfebe commented Sep 14, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@AndyScherzinger Do you mean, there should be more padding-left to accommodate the status icons? (When present)

@AndyScherzinger

AndyScherzinger commented Sep 14, 2023

Copy link
Copy Markdown
Member

Like this @fenn-cs

268013160-ed588d04-b131-4960-824f-4d77cd07be92

@nfebe

nfebe commented Sep 14, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

What about this?

Screenshot from 2023-09-14 16-18-47

Basically shifting everything together for more room. (Creates a bit more space for those without statuses but everything is aligned)

For more context : All items are now at the point where you drew the red line but unlike you I don't have photoshop :), so look hard :)

cc: @AndyScherzinger

@nfebe
nfebeforce-pushed the manual/backport/stable27/commit-in/40389 branch from ba7d7c8 to 4ebdf10CompareSeptember 14, 2023 15:35
@AndyScherzinger

AndyScherzinger commented Sep 14, 2023

Copy link
Copy Markdown
Member

I'd say fine for now and something we can further polish and discuss with @nextcloud/designers

@AndyScherzinger

AndyScherzinger commented Sep 14, 2023

Copy link
Copy Markdown
Member

For more context : All items are now at the point where you drew the red line but unlike you I don't have photoshop :), so look hard :)

I did this with M$ Paint 😆

@nfebe

nfebe commented Sep 14, 2023

Copy link
Copy Markdown
ContributorAuthor

/compile amend /

@nextcloud-command
nextcloud-commandforce-pushed the manual/backport/stable27/commit-in/40389 branch from 4ebdf10 to 2ac7575CompareSeptember 14, 2023 16:06
@AndyScherzinger
AndyScherzingerforce-pushed the manual/backport/stable27/commit-in/40389 branch from 2ac7575 to dfb6b5cCompareSeptember 20, 2023 09:31
@AndyScherzinger

AndyScherzinger commented Sep 20, 2023

Copy link
Copy Markdown
Member

/compile amend /

@blizzzblizzz mentioned this pull request Sep 20, 2023
Merged
4 tasks
@nfebe@nextcloud-command
Properly align all sharing-entry types
4755a47
SharingEntryLink and regular ShareEntry were not properly visually aligned
before this commit.
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command
nextcloud-commandforce-pushed the manual/backport/stable27/commit-in/40389 branch from dfb6b5c to 4755a47CompareSeptember 20, 2023 10:19
@nfebe
nfebe merged commit bee84a5 into stable27Sep 20, 2023
@nfebe
nfebe deleted the manual/backport/stable27/commit-in/40389 branch September 20, 2023 14:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzingerAndyScherzingerAndyScherzinger approved these changes
@artongeartongeartonge approved these changes
@PytalPytalPytal approved these changes
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@sorbaughsorbaughAwaiting requested review from sorbaugh

Assignees

No one assigned

Labels

3. to reviewWaiting for reviews27-feedback

Projects

None yet

Milestone

Nextcloud 27.1.1

Development

Successfully merging this pull request may close these issues.

4 participants

@nfebe@AndyScherzinger@artonge@Pytal