Uh oh!
There was an error while loading. Please reload this page.
Consider link shares in removeShare method in SharingTab - #40440
Merged
Conversation
nfebe
requested review from
AndyScherzinger, artonge, juliusknorr and szaimenSeptember 15, 2023 15:41
nfebe
commented
Sep 15, 2023
ContributorAuthor
/backport to stable27 |
nfebe
commented
Sep 15, 2023
ContributorAuthor
/compile amend / |
artonge
approved these changes
Sep 15, 2023
nextcloud-commandforce-pushed
the
40396-consider-link-shares-in-remove-share
branch
from
September 15, 2023 15:57
2fd960e to
6b81097Compareszaimen
approved these changes
Sep 15, 2023
AndyScherzinger
approved these changes
Sep 15, 2023
nfebe
enabled auto-merge
September 15, 2023 16:09
AndyScherzinger
commented
Sep 15, 2023
Member
Are these on purpose?
Just asking because I am no frontend dev, so sorry for simple questions... :S |
nfebeforce-pushed
the
40396-consider-link-shares-in-remove-share
branch
from
September 15, 2023 16:17
6b81097 to
691e2d9Comparenfebe
commented
Sep 15, 2023
ContributorAuthor
/compile amend / |
nfebe
commented
Sep 15, 2023
ContributorAuthor
I did a run build for benefit of doubt and seems like it. |
Currently, the `removeShare` method in the `SharingTab` view, does not take into account `linkShares`. Since link shares now shares thesame detail view with other share types, it should therefore be considered hence this commit. Resolves : #40396 Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-commandforce-pushed
the
40396-consider-link-shares-in-remove-share
branch
from
September 15, 2023 16:31
691e2d9 to
ef5bb42CompareThe backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
artonge added a commit
that referenced
this pull request
Sep 18, 2023
[stable27] Backport consider link shares in removeShare method in SharingTab #40440
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
removeSharemethod in theSharingTabview, does not take into accountlinkShares.Since link shares now shares the same detail view with other share types, it should therefore be considered hence this commit.
Resolves : #40396