Skip to content

[stable27] Backport consider link shares in removeShare method in SharingTab #40440 - #40448

Merged
artonge merged 1 commit into
stable27from
manual/backport/stable27/40440
Sep 18, 2023
Merged

[stable27] Backport consider link shares in removeShare method in SharingTab #40440 #40448
artonge merged 1 commit into
stable27from
manual/backport/stable27/40440

Conversation

@nfebe

@nfebenfebe commented Sep 15, 2023

Copy link
Copy Markdown
Contributor

Manual backport : #40440

Resolves#40396

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@artonge

Copy link
Copy Markdown
Collaborator

/compile amend /

Currently, the `removeShare` method in the `SharingTab` view,
does not take into account `linkShares`.
Since link shares now shares thesame detail view with other share types,
it should therefore be considered hence this commit.
Resolves : #40396
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command
nextcloud-commandforce-pushed the manual/backport/stable27/40440 branch from af816be to 65ff60aCompareSeptember 18, 2023 08:35
@artonge
artonge merged commit 5a22eb7 into stable27Sep 18, 2023
@artonge
artonge deleted the manual/backport/stable27/40440 branch September 18, 2023 10:37
@blizzzblizzz mentioned this pull request Sep 20, 2023
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsfeature: sharing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@nfebe@artonge@AndyScherzinger@szaimen