Uh oh!
There was an error while loading. Please reload this page.
add wrapper for external storage to ensure we don't get an mtime that is lower than we know it is - #40499
Merged
Merged
Conversation
icewind1991
requested review from
a team, ArtificialOwl, nfebe and sorbaugh
and removed request for
a teamSeptember 19, 2023 10:46
…w it is Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
known-mtime-wrapper
branch
from
September 19, 2023 11:58
8cd6cd8 to
ccf8843Compareartonge
approved these changes
Sep 20, 2023
nfebe
approved these changes
Sep 20, 2023
icewind1991
commented
Sep 20, 2023
MemberAuthor
/backport to stable27 |
icewind1991
commented
Sep 20, 2023
MemberAuthor
/backport to stable26 |
icewind1991
commented
Sep 20, 2023
MemberAuthor
/backport to stable25 |
come-nc
approved these changes
Sep 21, 2023
This was referenced Sep 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some storage servers will return the old mtime right after writes, causing Nextcloud to detect external changes when the correct mtime is return the next time around.
This adds some logic to not return mtimes lower than when we last touch the files ourselves to prevent these issues.