Skip to content

[stable25] add wrapper for external storage to ensure we don't get an mtime that is lower than we know it is - #40571

Closed
backportbot-nextcloud[bot] wants to merge 3 commits into
stable25from
backport/40499/stable25
Closed

[stable25] add wrapper for external storage to ensure we don't get an mtime that is lower than we know it is#40571
backportbot-nextcloud[bot] wants to merge 3 commits into
stable25from
backport/40499/stable25

Conversation

@backportbot-nextcloud

Copy link
Copy Markdown

Backport of #40499

@github-advanced-securitygithub-advanced-securityAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Psalm found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

use OCP\Files\Storage\IStorageFactory;
use OCP\Files\StorageNotAvailableException;
use OCP\IUser;
use Psr\Clock\ClockInterface;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a dependency on 25

@blizzzblizzz mentioned this pull request Oct 9, 2023
1 task
@blizzzblizzz added the 2. developing Work in progress label Oct 9, 2023
@blizzzblizzz removed this from the Nextcloud 25.0.13 milestone Oct 12, 2023
…w it is
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
icewind1991force-pushed the backport/40499/stable25 branch from 180f6d3 to a3af20fCompareOctober 24, 2023 15:09
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
icewind1991force-pushed the backport/40499/stable25 branch from a3af20f to 99e84deCompareOctober 25, 2023 13:17
return $result;
}

public function rename($source, $target) {

Check failure

Code scanning / Psalm

ParamNameMismatch

Argument 1 of OC\Files\Storage\Wrapper\KnownMtime::rename has wrong name $source, expecting $path1 as defined by OCP\Files\Storage\IStorage::rename
return $result;
}

public function rename($source, $target) {

Check failure

Code scanning / Psalm

ParamNameMismatch

Argument 2 of OC\Files\Storage\Wrapper\KnownMtime::rename has wrong name $target, expecting $path2 as defined by OCP\Files\Storage\IStorage::rename
return $result;
}

public function copy($source, $target) {

Check failure

Code scanning / Psalm

ParamNameMismatch

Argument 1 of OC\Files\Storage\Wrapper\KnownMtime::copy has wrong name $source, expecting $path1 as defined by OCP\Files\Storage\IStorage::copy
return $result;
}

public function copy($source, $target) {

Check failure

Code scanning / Psalm

ParamNameMismatch

Argument 2 of OC\Files\Storage\Wrapper\KnownMtime::copy has wrong name $target, expecting $path2 as defined by OCP\Files\Storage\IStorage::copy
@blizzz

Copy link
Copy Markdown
Member

:tumbleweed:

@blizzz

Copy link
Copy Markdown
Member

closing for lack of activity

@blizzzblizzz closed this Jan 24, 2024
@skjnldsv
skjnldsv deleted the backport/40499/stable25 branch March 14, 2024 07:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developingWork in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@blizzz@icewind1991@github-advanced-security@come-nc