Uh oh!
There was an error while loading. Please reload this page.
[stable25] add wrapper for external storage to ensure we don't get an mtime that is lower than we know it is - #40571
Closed
backportbot-nextcloud[bot] wants to merge 3 commits into
Closed
Conversation
backportbot-nextcloudBot
requested review from
artonge, come-nc, icewind1991 and nfebeSeptember 21, 2023 17:21
There was a problem hiding this comment.
Psalm found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
icewind1991
approved these changes
Sep 22, 2023
come-nc
requested changes
Sep 25, 2023
| use OCP\Files\Storage\IStorageFactory; | ||
| use OCP\Files\StorageNotAvailableException; | ||
| use OCP\IUser; | ||
| use Psr\Clock\ClockInterface; |
Contributor
There was a problem hiding this comment.
This is not a dependency on 25
…w it is Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
backport/40499/stable25
branch
from
October 24, 2023 15:09
180f6d3 to
a3af20fCompareSigned-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
backport/40499/stable25
branch
from
October 25, 2023 13:17
a3af20f to
99e84deCompare| return $result; | ||
| } | ||
| public function rename($source, $target) { |
Check failure
Code scanning / Psalm
ParamNameMismatch
| return $result; | ||
| } | ||
| public function rename($source, $target) { |
Check failure
Code scanning / Psalm
ParamNameMismatch
| return $result; | ||
| } | ||
| public function copy($source, $target) { |
Check failure
Code scanning / Psalm
ParamNameMismatch
| return $result; | ||
| } | ||
| public function copy($source, $target) { |
Check failure
Code scanning / Psalm
ParamNameMismatch
blizzz
commented
Dec 14, 2023
Member
:tumbleweed: |
blizzz
commented
Jan 24, 2024
Member
closing for lack of activity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #40499