Updates to new sharing flow by nfebe · Pull Request #40629 · nextcloud/server

nfebe · 2023-09-26T07:26:14Z

Dark mode

Before	Now

Footer background

Before	Now

nfebe · 2023-09-26T21:05:48Z

/compile amend /

nfebe · 2023-09-26T21:24:57Z

Follow up

Item	Action
The "Cancel" and primary button on the bottom need a backdrop to separate them a bit from the background, best a fade from color-main-background on the bottom to transparent on the top.	Done see screenshots above
Currently links are sorted below emails once created, but sorting should be: Links, mails, users	It is the case
If allow public upload admin setting is unchecked we should rename "Allow upload and editing" to "allow editing" and file drop / create permission should be disabled state	Done
The content of the sidebar is scroll-able when it should only be the content of the share tab	Done
It is confusing to have the download permission under "Custom permissions" as it is not taken into account for bundles	Moved up, and it is now just an advanced setting
Do not show unnecessary password expired message #40493	Done
Others	Dark mode corrections, see screenshot above/below

Dark mode view

jancborchardt

Nice improvements! Some feedback:

The gradient for the bottom buttons should be color-main-background on the bottom, currently it seems to use primary-light. It should not really be actively visible.
The gradient needs to extend to the full left and right of the sidebar and also to whichever much bottom padding the buttons have. Currently it starts directly at the buttons, which will lead to things looking cut off once you scroll.
The "Delete share" button also has a gradient on it for some reason?

nfebe · 2023-09-27T10:36:50Z

The gradient for the bottom buttons should be color-main-background on the bottom, currently it seems to use primary-light. It should not really be actively visible.

Yeah, this was mentioned from the original recommendation but I realized color-main-background makes not visual difference as it matches with the main background of the color theme. So can you please provide more context for me to understand the purpose of a non-visible gradient?

The gradient needs to extend to the full left and right of the sidebar and also to whichever much bottom padding the buttons have. Currently it starts directly at the buttons, which will lead to things looking cut off once you scroll.

I don't think it would be easy to achieve that, as everything is aligned inside the a container to keep the left-aligned items in place.

The "Delete share" button also has a gradient on it for some reason?

On master "Delete share" has no bg, unlike with 27, so I added a similar gradient. Could easily revert this.

cc: @jancborchardt

jancborchardt · 2023-09-27T12:26:43Z

The gradient for the bottom buttons should be color-main-background on the bottom, currently it seems to use primary-light. It should not really be actively visible.
Yeah, this was mentioned from the original recommendation but I realized color-main-background makes not visual difference as it matches with the main background of the color theme. So can you please provide more context for me to understand the purpose of a non-visible gradient?

Yep, here you go :) The gradient is invisible, yes, but it becomes visible when the content is big enough to make the container scroll (or the viewport is small enough).
If additional separation is needed, we could add an additional 2px border of color-main-background to the buttons.
Note the screenshots are based on the old mockups, so disregard any of that, only the gradient. :)

Current situation when scrolled	With the gradient

The gradient needs to extend to the full left and right of the sidebar and also to whichever much bottom padding the buttons have. Currently it starts directly at the buttons, which will lead to things looking cut off once you scroll.
I don't think it would be easy to achieve that, as everything is aligned inside the a container to keep the left-aligned items in place.

Right, actually if the gradient is color-main-background it is also not necessary to do that for left and right. For the bottom it is necessary though and could be done via negative margin?

The "Delete share" button also has a gradient on it for some reason?
On master "Delete share" has no bg, unlike with 27, so I added a similar gradient. Could easily revert this.

"Delete share" could just be a tertiary button as last element of the content, not as part of the button section which would then only have "Cancel" and "Update share".

nfebe · 2023-09-28T10:37:38Z

Thanks for the clarification @jancborchardt...

Both your concerns have been addressed.

jancborchardt

Looks good!

- Show enforced expiry date for new shares. - Improve quick share dropdown visibility in dark mode. - Prevent expiry date from showing expire for incoming shares. by updating the check for `share.passwordExpirationTime` to equally check for `undefined`. - Move "Download permission/attribute" from custom setting (as it is just another advanced setting and not an actual permission). - Show correct text for upload/editing when "allow public uploads" is enabled or disabled by admin. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

nfebe · 2023-10-02T11:12:05Z

/compile amend /

The default expiration date cannot be enforced if it is not enabled in the first place. Hence, the check for whether a share has an expiration date should not consider enforcements but only where the share expiry type is enabled. For example : Using `this.config.isDefaultExpireDateEnabled` instead of `this.config.isDefaultExpireDateEnforced` which can be verified by checking `isExpiryDateEnforced`. Resolves : #40612 Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

nfebe force-pushed the 40438-sharing-cleanup branch from 57f5bdf to f1b3336Compare September 26, 2023 11:31

nfebe mentioned this pull request Sep 26, 2023
⛑️ Polishing for new sharing design and flow -> 27.1.3 #40438
Closed
7 tasks

nfebe force-pushed the 40438-sharing-cleanup branch from f1b3336 to bfcadddCompare September 26, 2023 21:05

nfebe changed the title ~~WIP : Further polish sharing flow~~Updates to new sharing flowSep 26, 2023

nfebe marked this pull request as ready for review September 26, 2023 21:05

nfebe requested review from Pytal, jancborchardt, juliusknorr and susnux September 26, 2023 21:08

nfebe added feature: sharing 27-feedback labels Sep 26, 2023

nfebe added this to the Nextcloud 27.1.2 milestone Sep 26, 2023

nfebe requested a review from szaimen September 26, 2023 21:26

jancborchardt reviewed Sep 27, 2023
View reviewed changes

blizzz mentioned this pull request Sep 27, 2023
27.1.2 RC1 #40646
Merged

blizzz modified the milestones: Nextcloud 27.1.2, Nextcloud 27.1.3 Sep 28, 2023

nfebe force-pushed the 40438-sharing-cleanup branch from bfcaddd to a962925Compare September 28, 2023 10:35

nfebe requested a review from jancborchardt September 28, 2023 10:37

jancborchardt approved these changes Sep 28, 2023
View reviewed changes

This was linked to issues Sep 28, 2023
[Bug]: "Set expiration date" in share preview is not set when admin has set a default expiration date #40612
Closed
new share dropdown not good visible in dark mode #40395
Closed

nfebe force-pushed the 40438-sharing-cleanup branch from 8862b3b to 34d3624Compare September 28, 2023 12:49

nfebe requested a review from sorbaugh September 28, 2023 12:51

nfebe force-pushed the 40438-sharing-cleanup branch from 34d3624 to 890e8ceCompare September 28, 2023 12:51

nfebe force-pushed the 40438-sharing-cleanup branch 2 times, most recently from 929df20 to d209b56Compare September 28, 2023 13:55

nextcloud-command force-pushed the 40438-sharing-cleanup branch from d209b56 to 56bfab1Compare September 28, 2023 14:29

nfebe force-pushed the 40438-sharing-cleanup branch 2 times, most recently from 3e27e73 to 4360dd7Compare September 29, 2023 17:20

nfebe force-pushed the 40438-sharing-cleanup branch from 4360dd7 to 3ae7cd2Compare October 2, 2023 10:59

artonge approved these changes Oct 2, 2023
View reviewed changes

nextcloud-command force-pushed the 40438-sharing-cleanup branch from 3ae7cd2 to 0537bbdCompare October 2, 2023 11:29

nfebe mentioned this pull request Oct 2, 2023
[stable27] Updates to new sharing flow #40747
Merged

nfebe merged commit 8c2ff08 into masterOct 2, 2023

nfebe deleted the 40438-sharing-cleanup branch October 2, 2023 18:26

thgoebel mentioned this pull request Oct 28, 2023
[Bug]: "Set expiration date" can be disabled but it doesn't look disabled #41171
Closed
8 tasks

ornanovitch mentioned this pull request Nov 12, 2023
New sharing flow design #41397
Closed

Navigation Menu

Uh oh!

Uh oh!

Updates to new sharing flow - #40629

Updates to new sharing flow#40629
nfebe merged 2 commits into
masterfrom
40438-sharing-cleanup

nfebe commented Sep 26, 2023•
edited
Loading

Uh oh!

nfebe commented Sep 26, 2023

Uh oh!

nfebe commented Sep 26, 2023

Uh oh!

jancborchardt left a comment

Uh oh!

nfebe commented Sep 27, 2023

Uh oh!

jancborchardt commented Sep 27, 2023•
edited
Loading

Uh oh!

nfebe commented Sep 28, 2023

Uh oh!

jancborchardt left a comment

Uh oh!

nfebe commented Oct 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

nfebe commented Sep 26, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nfebe commented Sep 26, 2023

Uh oh!

nfebe commented Sep 26, 2023

Dark mode view

Uh oh!

jancborchardt left a comment

Choose a reason for hiding this comment

Uh oh!

nfebe commented Sep 27, 2023

Uh oh!

jancborchardt commented Sep 27, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nfebe commented Sep 28, 2023

Uh oh!

jancborchardt left a comment

Choose a reason for hiding this comment

Uh oh!

nfebe commented Oct 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nfebe commented Sep 26, 2023•
edited
Loading

jancborchardt commented Sep 27, 2023•
edited
Loading