Uh oh!
There was an error while loading. Please reload this page.
[stable27] Updates to new sharing flow - #40747
Merged
Merged
Conversation
artonge
approved these changes
Oct 2, 2023
Pytal
approved these changes
Oct 3, 2023
susnux
approved these changes
Oct 4, 2023
- Show enforced expiry date for new shares. - Improve quick share dropdown visibility in dark mode. - Prevent expiry date from showing expire for incoming shares. by updating the check for `share.passwordExpirationTime` to equally check for `undefined`. - Move "Download permission/attribute" from custom setting (as it is just another advanced setting and not an actual permission). - Show correct text for upload/editing when "allow public uploads" is enabled or disabled by admin. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebeforce-pushed
the
manual/backport/stable27/40629
branch
from
October 9, 2023 14:53
78c88da to
73430c5Comparenfebe
commented
Oct 9, 2023
ContributorAuthor
/compile amend / |
The default expiration date cannot be enforced if it is not enabled in the first place. Hence, the check for whether a share has an expiration date should not consider enforcements but only where the share expiry type is enabled. For example : Using `this.config.isDefaultExpireDateEnabled` instead of `this.config.isDefaultExpireDateEnforced` which can be verified by checking `isExpiryDateEnforced`. Resolves : #40612 Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-commandforce-pushed
the
manual/backport/stable27/40629
branch
from
October 9, 2023 15:52
73430c5 to
5f4c56eCompare Merged
blizzz
commented
Oct 9, 2023
Member
Cypress tests are failing, but probably not related? Are those known (or maybe even fixed)? |
nfebe
commented
Oct 9, 2023
ContributorAuthor
A rerun "fixed" it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport : #40629