feat(dav): implement personal absence settings by st3iny · Pull Request #40767 · nextcloud/server

st3iny · 2023-10-04T10:36:33Z

Resolves: Out-of-office: Implement settings UI with persistence in database #40616

Summary

The new absence form is hidden/disabled by default. It has to be manually enabled via the app config hide_absence_settings.

The help texts and descriptions might some need more work once the feature is fleshed out.

TODO

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)

+ $this->initialState->provideInitialState('hide_absence', $hideAbsence);
+ if (!$hideAbsence) {
+ try {
+ $absence = $this->absenceMapper->findByUserId($this->userId);


Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>

st3iny · 2023-11-07T16:27:51Z

Rebase round 2 to finally get green CI 🙃

hamza221

Tested ✅

nickvergessen · 2023-11-10T14:45:52Z

Could this be moved into an OCS endpoint so talk mobile clients could set the OOO as well?

ChristophWurst · 2023-11-14T13:21:31Z

Good idea! #41458

nickvergessen · 2023-11-14T14:31:03Z

+ lastDay: formatDateAsYMD(this.lastDay),
+ status: this.status,
+ message: this.message,
+ })


Should show success after this?

nickvergessen · 2023-11-14T14:31:08Z

+ async clearAbsence() {
+ this.loading = true
+ try {
+ await axios.delete(generateUrl('/apps/dav/settings/absence'))


Should show success after this?

tflidd · 2023-12-11T12:24:48Z

For translation, I'm not 100% sure of the strings Long absence Message and Short absence status,

in case of an absence, there is a short status message and a long message (e.g. if you hover over it)
or is there a short-term absence with a status message, and a long-term absence (e.g. after >5 min) where it shows a different message)?

I tend to the first option, but in this case it would make sense to define the different kind of absence status like in other software (e.g. busy, away, available, ....)

nickvergessen · 2023-12-11T13:17:07Z

The first one. the "Short" is set as "User status", the long one is shown in Mail and Talk close to the inputs iirc

st3iny added enhancement 2. developing Work in progress feature: dav labels Oct 4, 2023

st3iny added this to the Nextcloud 28 milestone Oct 4, 2023

st3iny self-assigned this Oct 4, 2023

st3iny mentioned this pull request Oct 11, 2023
feat(NcTextArea): implement new textarea component nextcloud-libraries/nextcloud-vue#4605
Merged
2 tasks

st3iny force-pushed the feat/dav/absence branch from 1ef66bf to 2a1094fCompare October 16, 2023 07:40

github-advanced-securityAI found potential problems Oct 16, 2023
View reviewed changes

st3iny force-pushed the feat/dav/absence branch from 2a1094f to 3d08bb7Compare October 16, 2023 07:46

ChristophWurst reviewed Oct 16, 2023
View reviewed changes

Comment threadapps/dav/lib/Migration/Version1029Date20231004091403.php Outdated

ChristophWurst reviewed Oct 16, 2023
View reviewed changes

Comment threadapps/dav/lib/Service/AbsenceService.php Outdated

ChristophWurst reviewed Oct 16, 2023
View reviewed changes

Comment threadapps/dav/lib/Settings/AvailabilitySettings.php

This was referenced Oct 23, 2023
feat(dav): implement personal absence settings backend #41051
Merged
Out-of-office: Implement settings UI with persistence in database #40616
Closed

st3iny force-pushed the feat/dav/absence branch from 3d08bb7 to c557c4aCompare October 25, 2023 15:41

github-advanced-securityAI found potential problems Oct 25, 2023
View reviewed changes

st3iny force-pushed the feat/dav/absence branch from 65b825d to 0956226Compare October 27, 2023 11:37

github-advanced-securityAI found potential problems Oct 27, 2023
View reviewed changes

Comment threadapps/dav/lib/Settings/AvailabilitySettings.php Fixed
Comment threadapps/dav/lib/Settings/AvailabilitySettings.php Fixed

skjnldsv mentioned this pull request Nov 1, 2023
chore: 28.0.0 beta 1 #41228
Merged

st3iny force-pushed the feat/dav/absence branch from 0956226 to e99916bCompare November 1, 2023 20:57

st3iny marked this pull request as ready for review November 1, 2023 20:57

st3iny added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 1, 2023

st3iny force-pushed the feat/dav/absence branch from e99916b to 0793e59Compare November 1, 2023 21:04

st3iny requested a review from ChristophWurst November 1, 2023 21:05

ChristophWurst reviewed Nov 2, 2023
View reviewed changes

Comment threadapps/dav/src/components/AbsenceForm.vue Outdated

st3iny force-pushed the feat/dav/absence branch from 0793e59 to e17b0ddCompare November 2, 2023 13:30

ChristophWurst approved these changes Nov 2, 2023
View reviewed changes

ChristophWurst requested review from hamza221 and kesselb November 6, 2023 11:58

blizzz mentioned this pull request Nov 6, 2023
28.0.0 beta 2 #41314
Merged

st3iny force-pushed the feat/dav/absence branch from e17b0dd to 1248c5dCompare November 7, 2023 13:36

feat(dav): implement personal absence settings
425e770
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>

st3iny force-pushed the feat/dav/absence branch from 1248c5d to 425e770Compare November 7, 2023 16:27

hamza221 approved these changes Nov 8, 2023
View reviewed changes

ChristophWurst merged commit 1d568a8 into masterNov 8, 2023

ChristophWurst deleted the feat/dav/absence branch November 8, 2023 04:51

ChristophWurst mentioned this pull request Nov 14, 2023
Out of office: expose setting endpoint via OCS #41458
Closed

nickvergessen reviewed Nov 14, 2023
View reviewed changes

ChristophWurst mentioned this pull request Nov 27, 2023
fix(dav): Make ooo settings a form and the message required #41759
Merged
4 tasks

Uh oh!

Uh oh!

Conversation

st3iny commented Oct 4, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

TODO

Checklist

Uh oh!

Uh oh!

Check notice

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

st3iny commented Nov 7, 2023

Uh oh!

hamza221 left a comment

Choose a reason for hiding this comment

Uh oh!

nickvergessen commented Nov 10, 2023

Uh oh!

ChristophWurst commented Nov 14, 2023

Uh oh!

nickvergessenNov 14, 2023

Choose a reason for hiding this comment

Uh oh!

nickvergessenNov 14, 2023

Choose a reason for hiding this comment

Uh oh!

tflidd commented Dec 11, 2023

Uh oh!

nickvergessen commented Dec 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

st3iny commented Oct 4, 2023•
edited
Loading