Skip to content

fix(dav): Make ooo settings a form and the message required - #41759

Merged
ChristophWurst merged 1 commit into
masterfrom
fix/dav/ooo-form-mandatory-message
Nov 29, 2023
Merged

fix(dav): Make ooo settings a form and the message required#41759
ChristophWurst merged 1 commit into
masterfrom
fix/dav/ooo-form-mandatory-message

Conversation

@ChristophWurst

@ChristophWurstChristophWurst commented Nov 27, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Summary

  • Converts the elements to a HTML-native form
  • Make the message mandatory
  • Add success toasts
  • Log errors

Checklist

@ChristophWurstChristophWurst added bug 3. to review Waiting for reviews feature: dav feature: caldav Related to CalDAV internals labels Nov 27, 2023
@ChristophWurstChristophWurst added this to the Nextcloud 29 milestone Nov 27, 2023
@ChristophWurstChristophWurst self-assigned this Nov 27, 2023
@ChristophWurst

ChristophWurst commented Nov 27, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to stable28

st3iny
st3iny approved these changes Nov 27, 2023
View reviewed changes

@st3inyst3iny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

Compiled assets are missing though.

@ChristophWurst
fix(dav): Make ooo settings a form and the message required
ecc1576
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 27, 2023
@ChristophWurst
ChristophWurstforce-pushed the fix/dav/ooo-form-mandatory-message branch from 9229547 to ecc1576CompareNovember 27, 2023 17:41
auto-merge was automatically disabled November 27, 2023 20:17

Pull Request is not mergeable

@ChristophWurst
ChristophWurst merged commit 4d2a32a into masterNov 29, 2023
@ChristophWurst
ChristophWurst deleted the fix/dav/ooo-form-mandatory-message branch November 29, 2023 07:54
@ChristophWurst

ChristophWurst commented Nov 29, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to stable28

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Nov 29, 2023
Merged
@blizzzblizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@st3inyst3inyst3iny approved these changes
@miaulalalamiaulalalamiaulalala approved these changes

Assignees

@ChristophWurstChristophWurst

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: caldavRelated to CalDAV internalsfeature: dav

Projects

💌 📅 👥 Groupware team
Archived in project

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

3 participants

@ChristophWurst@st3iny@miaulalala