feat(comments): Plug in comments into activity sidebar tab if available

[susnux]

• Resolves: 📑 Sidebar: combine file Activity and Comments into »Activity« timeline tab (possibly also "Versions") #658
• Replaces: Merge comments into Activity tab (if both apps are enabled) #41483
• Requires: feat(sidebar): Add frontend API that allows to register custom entries activity#1416

Summary

This is a more stable approach than #41483, if activity is enabled we plug into their stream and provide the comments.

Screenshot

vokoscreenNG-2023-11-15_12-22-39.mp4

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[nickvergessen]

This breaks the comments API when used by other apps again, as pointed out in the previous PR

[susnux]

This breaks the comments API when used by other apps again, as pointed out in the previous PR

Did you test this? This PR should only change the sidebar for the files app

[nickvergessen]

Did you test this?

yes, something is hardcoding the object type to files and try tomorrow again (or you install https://github.com/nextcloud/announcementcenter and try it yourself)

[susnux]

OK I know whats going on here... Have I ever said I hate mixins?
I had some weird issues were the type was not set, so I set it to files, well turns out the comments API sets it using mixins syntax from hell. I will fix this.

[susnux]

Should be fixed now @nickvergessen

Details

I really do not like code that hides what happens, in this case the comment type was injected only in one of the entry points as as a Mixin (**!**) instead of declaring it a prop so you know that it is there are need to be set / can be set.

[artonge]

Rebased and fixed come's comment

[artonge]

@nickvergessen I tested with announcement center. Should be fine now. :)

[susnux]

@nickvergessen resolved you comments should be fine now

Edit

I tested with announcement center. Should be fine now. :)

Oh we did this simultaneously :/

[nickvergessen]

Oh we did this simultaneously :/

All hail to git push --force-with-lease I guess

[nickvergessen]

Now the hardcoded files is back?
/remote.php/dav/comments/files/1

[nickvergessen]

Now the hardcoded files is back?

Only on posting, loading old comments works properly

[nickvergessen]

No resource type is set, what ressource type do you expect it to use?

The first argument is the resource type!?

[nickvergessen]

There were some mixing of the property name making it fallback to the default 'files'
I added a commit (and merged the recompile into the previous commit)

But now it works in files and announcements.

[susnux]

Cypress is unrelated (flaky user-creation test)