Skip to content

chore(comments): Drop dead code from comments app - #42174

Merged
susnux merged 1 commit into
masterfrom
chore/comments-cleanup-dead-code
Dec 13, 2023
Merged

chore(comments): Drop dead code from comments app#42174
susnux merged 1 commit into
masterfrom
chore/comments-cleanup-dead-code

Conversation

@susnux

Copy link
Copy Markdown
Contributor

Summary

Drop code that is not used anymore from repository - also drop "comments" script / entry point which is unused.

Checklist

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnuxsusnux added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Dec 12, 2023
@susnuxsusnux added this to the Nextcloud 29 milestone Dec 12, 2023
@susnux
susnux requested review from a team, ChristophWurst, Pytal, emoral435 and skjnldsv and removed request for a teamDecember 12, 2023 13:42
@susnux
susnux requested a review from artongeDecember 12, 2023 16:50

@artongeartonge left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the use of this script?

Comment threadapps/comments/.l10nignore
@susnux

Copy link
Copy Markdown
ContributorAuthor

Drone (samba) unrelated

@susnux
susnux merged commit 11e27ac into masterDec 13, 2023
@susnux
susnux deleted the chore/comments-cleanup-dead-code branch December 13, 2023 10:33
@susnux

Copy link
Copy Markdown
ContributorAuthor

What was the use of this script?

Old API that was dropped long time ago it seems. The only API used by other apps is the OCA.Comments.View used by e.g. announcement center

@artonge

Copy link
Copy Markdown
Collaborator

I remember @nickvergessen was also afraid to lose an API for Talk

@nickvergessen

nickvergessen commented Dec 13, 2023

Copy link
Copy Markdown
Member

Old API that was dropped long time ago it seems

It was not dropped. I prevent removal just last month....

This is public API:

/**
* Load the Comments app into the page
*
* @since 21.0.0
*/
publicfunctionload(): void {
$this->initialStateService->provideInitialState('comments', 'max-message-length', IComment::MAX_MESSAGE_LENGTH);
Util::addScript('comments', 'comments-app');
}

Can we just keep it for now?

We can deprecate and drop in 3 years if there are reasons apart from "just because"

@nickvergessen

Copy link
Copy Markdown
Member

See #41491 (review) and further

@nickvergessen

Copy link
Copy Markdown
Member

Reverting in #42207 to restore the nice functionality and public API

@susnux

susnux commented Dec 13, 2023

Copy link
Copy Markdown
ContributorAuthor

@nickvergessen that is a different script that is still provided. comments-app is still provided.

Meaning the public API is still there just some dead files are removed.

@blizzzblizzz mentioned this pull request Mar 5, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewstechnical debt🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@susnux@artonge@nickvergessen@emoral435