Uh oh!
There was an error while loading. Please reload this page.
chore(comments): Drop dead code from comments app - #42174
Conversation
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
artonge
left a comment
There was a problem hiding this comment.
What was the use of this script?
Uh oh!
There was an error while loading. Please reload this page.
susnux
commented
Dec 13, 2023
Drone (samba) unrelated |
susnux
commented
Dec 13, 2023
Old API that was dropped long time ago it seems. The only API used by other apps is the |
artonge
commented
Dec 13, 2023
I remember @nickvergessen was also afraid to lose an API for Talk |
It was not dropped. I prevent removal just last month.... This is public API: server/lib/private/Comments/Manager.php Lines 1615 to 1623 in aa5f037 Can we just keep it for now? We can deprecate and drop in 3 years if there are reasons apart from "just because" |
nickvergessen
commented
Dec 13, 2023
See #41491 (review) and further |
nickvergessen
commented
Dec 13, 2023
Reverting in #42207 to restore the nice functionality and public API |
@nickvergessen that is a different script that is still provided. Meaning the public API is still there just some dead files are removed. |
Summary
Drop code that is not used anymore from repository - also drop "comments" script / entry point which is unused.
Checklist